Skip to content

Added max-scroll feature #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added max-scroll feature #9

wants to merge 1 commit into from

Conversation

@Atish03
Copy link

@Atish03 Atish03 commented Nov 16, 2022

Closes #7

@Aman-Codes
Copy link
Member

Aman-Codes commented Nov 18, 2022

Hi @Atish03 Thank you for your contributions. Few changes that are required in this PR:

  1. Please sign the commits to ensure that check passes.
  2. Also could you take the parameter ( name it something like maxScrollAttempts) from the user in all the screenshot related post requests and then specify 10 as a default value if nothing or an invalid value (not a number greater than 0) is specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add max scroll limit in screenshot function to prevent timeout for infinite scroll page

2 participants

@Atish03 @Aman-Codes