Skip to content

Conversation

@ptahchiev
Copy link

Hi guys,

I have excluded welcome/ src/ packages/ overrides/ licenses/ cmd/ build/welcome/ and build/examples/
and now the webjar is around ~15MB (compared to 85MB before). My project seems to work just fine, however I'm not 100% sure it won't break anyone else's project.

@youk
Copy link

youk commented Apr 20, 2015

It would be great if you provide any official justification for these exclusions. Otherwise it is questionable why one should rely on custom modification like this.

@ptahchiev
Copy link
Author

I can't :( .. I'm not an extjs developer.. in fact what I've done is create a 5.1.0-my-SNAPSHOT version and upload it to my company repository to use that. I'm totally fine if you don't merge the pull request. The only thing I know is that it works for me.

@jamesward
Copy link
Member

It would be great to hear from some other users of this WebJar if this change will break something.

@kospiotr
Copy link

kospiotr commented Jan 3, 2016

Right now the whole webjar is complete package delivered by Sencha. Anybody can decide which modules/themes require.
For my project I'm not using webjar directly. I'm using maven-dependency-plugin to download and extract required content of the webjar, and then I copy extracted files to desired location.

Here are my snippets:

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-dependency-plugin</artifactId>
                <executions>
                    <execution>
                        <id>unpack-swagger-ui</id>
                        <phase>generate-resources</phase>
                        <goals>
                            <goal>unpack</goal>
                        </goals>
                        <configuration>
                            <artifactItems>
                                <artifactItem>
                                    <groupId>org.webjars</groupId>
                                    <artifactId>extjs</artifactId>
                                    <version>${extjs.version}</version>
                                    <type>jar</type>
                                    <destFileName>test-dependency</destFileName>
                                    <includes>
                                        META-INF/resources/webjars/extjs/${extjs.version}/build/*.*,META-INF/resources/webjars/extjs/${extjs.version}/build/classic/**/*.*,META-INF/resources/webjars/extjs/${extjs.version}/build/packages/**/*.*
                                    </includes>
                                    <outputDirectory>${project.build.directory}/generated-resources/extjs
                                    </outputDirectory>
                                </artifactItem>
                            </artifactItems>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
            <plugin>
                <artifactId>maven-resources-plugin</artifactId>
                <executions>
                    <execution>
                        <id>copy-extjs-resources</id>
                        <phase>process-resources</phase>
                        <goals>
                            <goal>copy-resources</goal>
                        </goals>
                        <configuration>
                            <outputDirectory>${project.build.outputDirectory}/static/extjs</outputDirectory>
                            <resources>
                                <resource>
                                    <directory>
                                        ${project.build.directory}/generated-resources/extjs/META-INF/resources/webjars/extjs/${extjs.version}/build
                                    </directory>
                                </resource>
                            </resources>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

I would prefere to have full package and decide whch parts can I use in the project rather than receiving a part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants