Skip to content

Conversation

@alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fix re-hook

Breaking Changes

No

Additional Info

WIP on tests

@alexander-akait
Copy link
Member Author

alexander-akait commented Aug 14, 2025

@ricardogobbosouza Hello, can you clarify why we use compiler.hooks.thisCompilation, but compiler.hooks.compilation in eslint-plugin-webpack?

Is it a bug? Because this plugin doesn't work for child compilations

@alexander-akait alexander-akait merged commit 0115aea into master Aug 14, 2025
51 checks passed
@alexander-akait alexander-akait deleted the fix-don't-rehook branch August 14, 2025 20:03
@ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza Hello, can you clarify why we use compiler.hooks.thisCompilation, but compiler.hooks.compilation in eslint-plugin-webpack?

Is it a bug? Because this plugin doesn't work for child compilations

Hi @alexander-akait
I believe it went unnoticed

@alexander-akait
Copy link
Member Author

@ricardogobbosouza Should we fix it here? I think eslint-webpack-plugin and stylelint-webpack-plugin should have the same structure (hooks, threads logic and etc), maybe even we can union them into lint-webpack-plugin and provide ability to use custom lint function + built-in like stylelint and eslint, we will have less plugin and code and it will be more comfortable to maintenance, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants