Refactor: Minor safety and modernization updates in processSchema by Manas-Dikshit · Pull Request #34 · webpack/tooling

Manas-Dikshit · 2026-03-02T18:59:22Z

Changes

Null and type checks (!json || typeof json !== 'object') have been added for improved recursion safety.
Optional chaining (visitor?.method) has been used instead of potentially throwing an error.
Object.keys() has replaced the use of for...in for enhanced compatibility.
!Array.isArray() checks have been included for object expectations.

Impact

No breaking changes have been made.
Improved error safety and code clarity.
Identical functionality remains for backward compatibility.
Compatible with modern Node.js runtimes and linting configurations.

alexander-akait

Is this AI generated code?

Manas-Dikshit · 2026-03-03T12:07:36Z

Hey @alexander-akait — I used AI assistance mainly for syntax suggestions and safety checks, but the logic and final implementation were manually reviewed and tested by me. It’s fully aligned with the existing behavior.

These are AI assisted.

If there is any mistakes or logic fall in the refined code then kindly suggest the changes.

lib/process-schema.js

Updated JSDoc comments for better clarity and added type definitions.

lib/process-schema.js

Updated type definitions for SchemaVisitor and parameters in the processSchema function to use JSONSchema.

lib/process-schema.js

Updated comments for clarity and restructured constant definitions for nested schema traversal.

lib/process-schema.js

alexander-akait · 2026-03-04T11:32:06Z

lib/process-schema.js

+ * @property {unknown} [const]
+ * @property {unknown} [default]
+ * @property {Record<string, unknown>} [examples]
+ * @property {Record<string, unknown>} [other] - Any additional schema fields.


Just use it from types - https://github.com/webpack/schema-utils/blob/main/package.json#L48

Refactor processSchema for improved safety and readability

b7a2eb9