Add adjustable refill rate to RotatingTokenBucketLimiter#36
Open
parsnips wants to merge 3 commits intowebriots:mainfrom
Open
Add adjustable refill rate to RotatingTokenBucketLimiter#36parsnips wants to merge 3 commits intowebriots:mainfrom
parsnips wants to merge 3 commits intowebriots:mainfrom
Conversation
Author
|
The failing The workflow runs on - uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}For this PR, The branch is already pushed here: A minimal fix is to check out the PR head repo explicitly, e.g.: - uses: actions/checkout@v4
with:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.ref }}I verified locally that |
parsnips
added a commit
to parsnips/spreader
that referenced
this pull request
Mar 28, 2026
Depends on webriots/rate#36 for RotatingTokenBucketLimiter.SetRefillRate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetRefillRateandRefillRatetoRotatingTokenBucketLimiterDownstream Context
parsnips/spreaderuses this to split one global scheduling rate across a changing number of publishers in a distributed system255and adjusts only refill rate so counts above255still preserve the intendedtargetRate / publisherCountsharespreaderis currently using this via a temporaryreplaceto the forked branch and has regression coverage for the consumed-capacity case that motivated the changeTesting
go test ./...