This repository was archived by the owner on May 13, 2024. It is now read-only.
Added arguments to make the server accessible remotely.#756
Open
bkeller-vuzix wants to merge 1 commit intowebrtc:masterfrom
Open
Added arguments to make the server accessible remotely.#756bkeller-vuzix wants to merge 1 commit intowebrtc:masterfrom
bkeller-vuzix wants to merge 1 commit intowebrtc:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
alvestrand
reviewed
Aug 23, 2023
The original flags were requiring TLS be used, and that remote machines be whitelisted. Those are now docker build arguments so they can be disabled. Also changed the instructions to tag the docker image so the command is more consistent. Update Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original flags were requiring TLS be used, and that remote machines be whitelisted. Those are now docker build arguments so they can be disabled.
Also changed the instructions to tag the docker image so the command is more consistent.