Refactor DataTracker to simplify state handling#87
Open
boivie wants to merge 1 commit intowebrtc:mainfrom
Open
Refactor DataTracker to simplify state handling#87boivie wants to merge 1 commit intowebrtc:mainfrom
boivie wants to merge 1 commit intowebrtc:mainfrom
Conversation
DataTracker previously maintained a separate `seen_packet` boolean to track whether the first DATA chunk had been received. This was required because RFC 9260 mandates an immediate SACK for the first received packet. This change merges that boolean into `AckState` by introducing a new `AckState::Initial` variant, to simplify the code a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataTracker previously maintained a separate
seen_packetboolean to track whether the first DATA chunk had been received. This was required because RFC 9260 mandates an immediate SACK for the first received packet.This change merges that boolean into
AckStateby introducing a newAckState::Initialvariant, to simplify the code a bit.