Skip to content

Conversation

@tmatth
Copy link

@tmatth tmatth commented Jul 14, 2014

Also remove broken lines that are not required.

@tmatth
Copy link
Author

tmatth commented Jul 14, 2014

Fixes issue #16

Also remove broken lines that are not required.
@Lekensteyn
Copy link

LGTM.

@wernerd
Copy link
Owner

wernerd commented Jan 11, 2015

This fix will be in the next release.

Werner

Am 11.01.2015 um 14:59 schrieb Peter Wu:

LGTM.


Reply to this email directly or view it on GitHub #17 (comment).

Werner Dittmann
email: Werner.Dittmann@t-online.de
cell: +49 173 44 37 659
PGP key: 82EF5E8B

@keszybz
Copy link

keszybz commented Apr 19, 2015

This patch does not seem right:

  • previous way to include files (#include <libzrtpcpp/xxx.h>) still works, but now one can also use #include <xxx.h>. Some people will use one some the other.
  • more importantly, not all header files installed by libzrtpcpp are properly namespaced, and this might lead to collisions (for this to work they should all start with Zrtp prefix or something). For example there's common/osSpecifics.h which is too generic to put in the include path.

I think it would be much better to internally include all headers using #include "libzrtpcpp/xxx.h", and only allow users of this library to use #include <libzrtpcpp/xxx.h>, and not modify cflags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants