tests: add comprehensive unit tests for critical coverage gaps#55
Closed
brendanjryan wants to merge 1 commit intowevm:masterfrom
Closed
tests: add comprehensive unit tests for critical coverage gaps#55brendanjryan wants to merge 1 commit intowevm:masterfrom
brendanjryan wants to merge 1 commit intowevm:masterfrom
Conversation
|
@brendanjryan is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
Add 61 new unit tests across 8 files targeting the most critical untested code paths identified via coverage analysis: - changelog_entry: extract_pr_number, read_all, write, delete roundtrips - changelog_writer: generate_entry_with_date with various bump types - ecosystems/rust: read/write version, update_dependency_version - workspace: find_root for Rust workspaces, Python, error cases - plan: assemble with dependent bumps, fixed/linked groups, ignore - config: load/save roundtrip, partial config defaults, malformed TOML - graph: all_dependents transitive/diamond, dependencies, edge cases - lib: BumpType::from_str valid/invalid paths
brendanjryan
force-pushed
the
tests/coverage-gaps
branch
from
96ab5fb to
50b5fe3
Compare
Contributor
Author
|
pulled in another pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 61 new unit tests across 8 files, targeting the most critical untested code paths identified via
cargo-tarpaulincoverage analysis.Coverage gaps addressed
extract_pr_number(squash/merge/missing/multiple),read_all(multi-file, README skip, empty/missing dir),write/deleteroundtripsgenerate_entry_with_date— single patch, mixed bump types, major-only, multiline summaries, no-match caseread_version,write_version(including field preservation),update_dependency_versionacross deps/dev-deps/workspace-depsfind_rootfor Rust workspaces, standalone crates, Python projects, and error case;get_package,package_names,is_initialized,changelog_dirassemblewith dependent bumps (patch/minor/none), fixed groups, linked groups (both/single releasing), ignore listall_dependentstransitive chains + diamond deps,dependencies, nonexistent packages, isolated nodesBumpType::from_strvalid/invalid/case-insensitiveNotable finding
RustAdapter::read_versionpanics (rather than returningErr) when[package].versionis missing — documented with#[should_panic]test.Test results
All 116 tests pass (88 unit + 13 golden + 15 python adapter).