fix: return 410 ChannelClosed for zero-deposit settled channels#243
Open
fix: return 410 ChannelClosed for zero-deposit settled channels#243
Conversation
During settlement the escrow contract may zero the deposit before setting the finalized flag. This creates a window where finalized=false but deposit=0. Without this guard, vouchers against such channels return 402 AmountExceedsDepositError instead of 410 ChannelClosedError. The 410 response tells clients to clear their local channel state and open a fresh channel on the next request, which is the correct recovery path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During settlement the escrow contract may zero the deposit before setting the
finalizedflag. This creates a brief window wherefinalized=falsebutdeposit=0.Without this guard, vouchers against such channels return 402 (
AmountExceedsDepositError) instead of the correct 410 (ChannelClosedError).The 402 causes clients (e.g. Foundry's MPP transport) to misinterpret the error — they think the voucher amount is wrong and retry with the same stale channel state. With 410, clients correctly clear their local channel state and open a fresh channel on the next request.
Fix
Add a guard in
verifyAndAcceptVoucher(after thefinalizedandcloseRequestedAtchecks): ifdeposit === 0on a channel with a real payer, throwChannelClosedError(410).How to reproduce
finalizedis set