fix: clearTimeout in waitForUserOperationReceipt #4058
Merged
+20
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ddee030 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Please add a changeset. |
Contributor
Author
@jxom Changeset was added |
Contributor
Author
|
@jxom any update mate? |
This was referenced Nov 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the timeout in
waitForUserOperationReceiptwas not properly cleared after the receipt was returned or an error occurred. This could cause unnecessary delayed executions or memory leaks in long-running applications.What this PR does:
Why it matters:
Without clearing the timeout, the process may retain references to the pending timer callback. For example, when
waitForUserOperationReceiptis used in avitesttest, the test may hang for up to 120,000 ms (the default timeout) because the testing framework detects ongoing I/O operations that were never cleared.