Fix #1127: Move exercise search to new endpoint #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrated from /exercise/search/ to /exerciseinfo/ endpoint - Updated query parameters (term->name__search, language->language__code) - Added data transformation from exerciseinfo format to ExerciseSearchResponse - Added error handling for invalid responses"
|
sorry, I meant we completely throw away ExerciseSearchResponse and just return regular exercise objects! then we don't have to keep two things around that basically do the same thing |
- Removed ExerciseSearchResponse transformation layer - Changed searchExerciseTranslations to return Exercise[] directly - Updated NameAutocompleter to work with Exercise objects - Updated ExerciseOverview callback to use Exercise.id - Uses ExerciseAdapter for data transformation
- Updated searchResponse mock data to use Exercise objects - Added Exercise import in NameAutocompleter.test.tsx - Updated test assertions to use expect.any(Exercise)"
…m/FilipCuper/react into fix/exercise-search-endpoint-1127
rolandgeider
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.