adds support for auth proxy header #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyJhb
force-pushed
the
proxyauthheader
branch
4 times, most recently
from
714efe6 to
2a306f4
Compare
eyJhb
changed the title
eyJhb
force-pushed
the
proxyauthheader
branch
2 times, most recently
from
d46d469 to
7a7a494
Compare
Useful if you have authentication in front of wger, and want to use that instead of wgers authentication/signup methods.
Contributor
Author
|
Maybe this should only be checked for |
5 tasks
Member
|
BTW I haven't forgotte about this PR, but since it would add a new auth method I'd like to make sure we do it right. I've added this to the 2.4 backlog (so after the flexible routines get merged) |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for authentication via a proxy header by introducing new settings, middleware, and an authentication backend, along with tests to verify the feature.
- Added new settings and middleware in wger/settings_global.py to support proxy-based authentication.
- Introduced AuthProxyHeaderMiddleware and AuthProxyUserBackend in wger/core to authenticate users based on a trusted header.
- Added comprehensive tests in wger/core/tests to validate the auth proxy behavior and updated the production settings.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wger/settings_global.py | Added new settings and registered the auth proxy middleware and backend. |
| wger/settings.tpl | Documented usage of the auth proxy header setting. |
| wger/core/tests/test_auch_proxy_middleware.py | Added tests covering various auth proxy scenarios. |
| wger/core/middleware.py | Introduced middleware to authenticate users via a trusted proxy header. |
| wger/core/backends.py | Implemented a custom backend for proxy header-based authentication. |
| extras/docker/production/settings.py | Configured the necessary auth proxy settings for the production environment. |
Comments suppressed due to low confidence (1)
wger/core/tests/test_auch_proxy_middleware.py:1
- [nitpick] The file name 'test_auch_proxy_middleware.py' appears to have a typo; consider renaming it to 'test_auth_proxy_middleware.py' for clarity.
# This file is part of wger Workout Manager.
We now properly redirect logged-out users to the login page, instead of only showing a permission denied error. If a user is already logged in, and they visit the page, they are redirected to the url in "next". We also now only apply the auth header checks there.
This allows setting directly these values for new users created through the auth proxy.
Otherwise, it is possible to land on the login page being logged-in, but having to do a reload first to actually being redirected to the dashboard.
rolandgeider
force-pushed
the
proxyauthheader
branch
from
d5ce854 to
e374712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful if you have authentication in front of wger, and want to use that instead of wgers authentication/signup methods.
Proposed Changes
Added a new setting, which can be used to setup proxy auth header, e.g. using Authelia to authenticate + create users on the instance.
Fixes #1847 , and potential VERY SIMPLE solution for #1805 ( #1797 )
Please check that the PR fulfills these requirements
Other questions
(e.g. database migration)? No
Remaining work