-
Notifications
You must be signed in to change notification settings - Fork 1
[ABI Dependency] Best-Effort support for pip
#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DEKHTIARJonathan
wants to merge
10
commits into
main
Choose a base branch
from
abi_dependency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
168a2a0 to
5b994c1
Compare
konstin
reviewed
Oct 13, 2025
mgorny
reviewed
Oct 13, 2025
2fffbf5 to
657e80d
Compare
657e80d to
9a4f968
Compare
Co-authored-by: Michał Górny <mgorny@quansight.com>
mgorny
reviewed
Oct 30, 2025
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional and "best effort" implementation for
pip.Should work just fine.
Implementation details
plugin venv isolation.export VARIANT_ABI_DEPENDENCY=packageA==1.2.3,...,packageZ==7.8.9Should support these usecases
pip install torch # `torch` is pre-installed and automatically fed by `variantlib` pip install vllm flash-attnVersioning
The interface supports "sort of range support" and not exclusively
major.minor.micropinningexport VARIANT_ABI_DEPENDENCY="torch==2.8.0"=> only2.8.0torch releaseexport VARIANT_ABI_DEPENDENCY="torch==2.8"=> only>=2.8,<2.9torch releasesexport VARIANT_ABI_DEPENDENCY="torch==2"=> only>=2,<3torch releasesWhich allows developers for different package to express different level of compatibility.
It should be noted that the package maintainers can also combine
abi_dependencytags to express anORmatch:abi_depedency :: torch :: 2.8.0=> exact2.8.0matchabi_depedency :: torch :: 2.9.0=> exact2.9.0matchabi_depedency :: torch :: 3=>>=3,<4match=> Any version of
torchthat matches one of the above will be compatible.