media: re-add Safari17Handler to fix simulcast max bitrate#791
Open
kevinwhereby wants to merge 2 commits intomainfrom
Open
media: re-add Safari17Handler to fix simulcast max bitrate#791kevinwhereby wants to merge 2 commits intomainfrom
kevinwhereby wants to merge 2 commits intomainfrom
Conversation
this is taken directly from the mediasoup-client repo (with imports adjusted) the next commit will add the changes that make it work with maxBandwidth for clarity
🦋 Changeset detectedLatest commit: bbd2e1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
encodings aren't respected if provided in `addTransceiver` so we wait until the connection is negotiated
kevinwhereby
force-pushed
the
kevinhanna/cob-2031-re-add-safari17handleron
branch
from
6ab2c45 to
bbd2e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Fixes the Safari12 implementation in mediasoup-client to limit simulcast bitrate when
maxBitrateis providedRelated Issue:
https://linear.app/whereby/issue/COB-2031/re-add-safari17handleron
Testing
pnpm buildthis repocd packages/media && yalc publishyalc add @whereby.com/media@2.2.0?stats?statsScreenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Additional Information
see linear ticket for module resolution issue discussion