camera-effects: lock engine access when it is recreated#847
Draft
camera-effects: lock engine access when it is recreated#847
Conversation
Add an `_engineLock` to Processor, and use it to prevent unintended `engine.dispose()` race condition between `updateParams` and `updateVideoSize`.
🦋 Changeset detectedLatest commit: 53f8a0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary release has been published to npm. You can test the release by installing the newly published version: pnpm add @whereby.com/camera-effects@0.0.0-canary-20260119084133 |
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary release has been published to npm. You can test the release by installing the newly published version: pnpm add @whereby.com/camera-effects@0.0.0-canary-20260130110354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Add an
_engineLockto Processor, and use it to prevent unintendedengine.dispose()race condition betweenupdateParamsandupdateVideoSize.Related Issue:
Testing
mediaStream.getVideoTracks()[0].applyConstraints({height: { exact: 360 }})and try to quickly change the effects.There should be no
Unhandled Promise Rejection: TypeError: null is not an object (evaluating 'this.engine.updateBackgroundFrame')error in the console.Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Additional Information