Added image layout #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
toonvandenbos
left a comment
toonvandenbos
left a comment
There was a problem hiding this comment.
Il ne manque pas le layout Hiker CMS ?
Comment on lines
14
to
27
| /** | ||
| * The LayoutImage's title. | ||
| */ | ||
| public string $image; | ||
|
|
||
| /** | ||
| * The LayoutImage's image. | ||
| */ | ||
| public string $alt; | ||
|
|
||
| /** | ||
| * The LayoutImage's image alt. | ||
| */ | ||
| public string $caption; |
Member
There was a problem hiding this comment.
Les doc blocks sont fucked up
Member
Author
oui.. |
toonvandenbos
approved these changes
Aug 21, 2025
Comment on lines
+45
to
+47
| Text::make('Alternative text', 'alt') | ||
| ->rules('required') | ||
| ->help('<strong>Hidden</strong>. An alternative text is used to give a description of the content of an image so that the visually impaired and search engines can understand the image.'), |
Member
There was a problem hiding this comment.
Il faut placer le alt juste en-dessous de l'image, puis la caption.
components/image/Layout.php
Outdated
| DataList::make() | ||
| ->row('Image', ImageComponent::make(Storage::url($this->image))->aspectRatio('16/9')) | ||
| ->row('Caption', TextComponent::make($this->caption)) | ||
| ->row('Alternative text', TextComponent::make($this->alt)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.