Year in Review Reading List with A/B Test #6045

Williamrai · 2025-10-24T17:07:01Z

What does this do?

creates reading list based on year in review with A/B Test

Phabricator:
https://phabricator.wikimedia.org/T407656

…es the strings xml - code fixes

… save that list and code to update ui for that list - ui/code fixes and adds strings resources

- updates YearInReviewSurvey.kt to YearInReviewDialog.kt - code fixes/ui fixes

…e "new" indicator once the user opens the new list - code fixes

# Conflicts: # app/src/main/java/org/wikipedia/yearinreview/YearInReviewScreenDeck.kt # app/src/main/res/values/strings_no_translate.xml

cooltey

One issue found:

After the reading list is created, we will still see the "Reading list created" after going back to the main reading lists screen. Not sure if this is something needed to confirm with PM.

app/src/main/java/org/wikipedia/readinglist/ReadingListFragmentViewModel.kt

app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.kt

cooltey · 2025-10-29T19:02:08Z

app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.kt

+    private fun hideNewIndicatorForRecentSavedList() {
+        if (recentPreviewSavedReadingList != null) {
+            val pos = displayedLists.indexOfFirst { it is ReadingList && it.id == recentPreviewSavedReadingList?.id }
+            if (pos != -1) {
+                adapter.notifyItemChanged(pos)
+            }
+            recentPreviewSavedReadingList = null
+        }
+    }


Not sure but do we really need this?

From the design

app/src/main/java/org/wikipedia/yearinreview/YearInReviewDialog.kt

cooltey · 2025-10-29T19:04:14Z

app/src/main/java/org/wikipedia/yearinreview/YearInReviewViewModel.kt

        const val MIN_SLIDES_BEFORE_SURVEY = 2
+        const val MIN_SLIDES_FOR_CREATING_YIR_READING_LIST = 1
+        const val MIN_ARTICLES_FOR_CREATING_YIR_READING_LIST = 5
+        const val CUT_OFF_DATE_FOR_SHOWING_YIR_READING_LIST_DIALOG = "2026-03-31T23:59:59Z"


Do we need this in RemoteConfig?

Do you mean not adding these values here in YearInReviewModel?

Since we are putting all the dates in the feed/configuration endpoint, maybe we can think about putting this date into the remote configuration, too.

But we can do this later if we decide to move this to the remoteConfig.

Williamrai · 2025-10-29T20:16:19Z

One issue found:

After the reading list is created, we will still see the "Reading list created" after going back to the main reading lists screen. Not sure if this is something needed to confirm with PM.

I am not sure I follow. could you share a quick recording or screenshot so I can see what you mean?

cooltey · 2025-10-29T20:35:12Z

One issue found:
After the reading list is created, we will still see the "Reading list created" after going back to the main reading lists screen. Not sure if this is something needed to confirm with PM.

I am not sure I follow. could you share a quick recording or screenshot so I can see what you mean?

It's the snackbar, and I think this is something redundant because you have already seen it after creating the list. But this probably should be confirmed with the PMs.

…ogs and reading list - adds loading and error UI for year in review reading list - code fixes

Williamrai · 2025-10-29T21:09:12Z

One issue found:
After the reading list is created, we will still see the "Reading list created" after going back to the main reading lists screen. Not sure if this is something needed to confirm with PM.

I am not sure I follow. could you share a quick recording or screenshot so I can see what you mean?

It's the snackbar, and I think this is something redundant because you have already seen it after creating the list. But this probably should be confirmed with the PMs.

Figma does not have this design so removing it. Added a check for not showing snackbar when its from year in review reading list.

…ated

* - adds logic/enum state prefs to show yir reading list survey * - code fixes * - code fix

cooltey · 2025-11-03T19:51:11Z

app/src/main/java/org/wikipedia/yearinreview/YearInReviewViewModel.kt

        const val MIN_SLIDES_BEFORE_SURVEY = 2
+        const val MIN_SLIDES_FOR_CREATING_YIR_READING_LIST = 1
+        const val MIN_ARTICLES_FOR_CREATING_YIR_READING_LIST = 5
+        const val CUT_OFF_DATE_FOR_SHOWING_YIR_READING_LIST_DIALOG = "2026-03-31T23:59:59Z"


Since we are putting all the dates in the feed/configuration endpoint, maybe we can think about putting this date into the remote configuration, too.

But we can do this later if we decide to move this to the remoteConfig.

cooltey · 2025-11-03T19:54:14Z

app/src/main/java/org/wikipedia/yearinreview/YearInReviewDialog.kt

+import java.time.ZoneOffset
+
+object YearInReviewDialog {
+    private val userGroup = if (Prefs.appInstallId.hashCode() % 2 == 0) "A" else "B"


I am kind of concerned about this:

Will the same group of users fall into the same user group if we keep using the app install ID as the seed?

Similar to this one

apps-android-wikipedia/app/src/main/java/org/wikipedia/donate/donationreminder/DonationReminderHelper.kt

Lines 185 to 187 in 3020fa9

private fun getUserGroup(): String {

return if (Prefs.appInstallId.hashCode() % 2 == 0) "A" else "B"

}

I think there's a proper way of assigning the users to a group by following the logic in ABTest.assignGroup().

yes this logic will always keep the user in the same group because the appInstallId is always same for the app if (Prefs.appInstallId.hashCode() % 2 == 0) "A" else "B". The ABTest.assignGroup() logic has a preference to store the test group, but if we do something similar to assignGroup() then we would have to add another preference to save this user group.

I think we can reuse the ABTest class to create an AB test group, which makes more sense in this case.

- initial work (adds string resources, creates dialog)

fc0239a

Williamrai added the WIP Work in progress label Oct 24, 2025

Williamrai requested review from cooltey and dbrant as code owners October 24, 2025 17:07

Williamrai and others added 9 commits October 24, 2025 13:53

Merge branch 'main' into yir-reading-list

043bf89

- adds logic that determines whether to show the dialog and adds copi…

de60b8b

…es the strings xml - code fixes

Merge branch 'main' into yir-reading-list

17f243d

- adds code to generate reading list based on year in review, code to…

dd01612

… save that list and code to update ui for that list - ui/code fixes and adds strings resources

- updates logic to show yir reading list dialog

5f433a9

- updates YearInReviewSurvey.kt to YearInReviewDialog.kt - code fixes/ui fixes

- Adds logic to display the dialog on the next app launch and hide th…

260a055

…e "new" indicator once the user opens the new list - code fixes

Merge remote-tracking branch 'origin/main' into yir-reading-list

5447206

# Conflicts: # app/src/main/java/org/wikipedia/yearinreview/YearInReviewScreenDeck.kt # app/src/main/res/values/strings_no_translate.xml

- code fixes

cd3cd80

Merge branch 'main' into yir-reading-list

43664cf

Williamrai added Ready for Review and removed WIP Work in progress labels Oct 29, 2025

Williamrai added 2 commits October 29, 2025 11:27

- add comments and code fixes

7464caf

- update hiding new indicator logic

2cf0510

cooltey requested changes Oct 29, 2025

View reviewed changes

Williamrai and others added 3 commits October 29, 2025 16:40

- use remote config to get start and end date for year in review dial…

b5d7fee

…ogs and reading list - adds loading and error UI for year in review reading list - code fixes

Merge branch 'main' into yir-reading-list

79759fe

- adds check for not showing snackbar for year in review reading list

5a966b6

Williamrai and others added 6 commits October 29, 2025 18:02

- lint fix

9daa975

Merge branch 'main' into yir-reading-list

07b3be2

- code fix for showing New indicator

9331454

- adds a new variable to open saved page when yir reading list is cre…

dc97dc4

…ated

- show yir reading list dialog in page activity

383daa9

Merge branch 'main' into yir-reading-list

eb9e7b2

cooltey and others added 5 commits October 31, 2025 10:29

Merge branch 'main' into yir-reading-list

e3c4154

Yir reading list survey (#6064)

725e959

* - adds logic/enum state prefs to show yir reading list survey * - code fixes * - code fix

Merge branch 'main' into yir-reading-list

000745f

Merge branch 'main' into yir-reading-list

d9592bd

Merge branch 'main' into yir-reading-list

292d896

cooltey reviewed Nov 3, 2025

View reviewed changes

Williamrai and others added 3 commits November 4, 2025 09:30

Merge branch 'main' into yir-reading-list

ac3cbcd

Merge branch 'main' into yir-reading-list

773e8fa

- adds AB test class for year in review reading list

18251ba

Williamrai requested a review from cooltey November 4, 2025 18:54

cooltey approved these changes Nov 4, 2025

View reviewed changes

cooltey merged commit c77e2b6 into main Nov 4, 2025
1 check passed

cooltey deleted the yir-reading-list branch November 4, 2025 19:21

	private fun getUserGroup(): String {
	return if (Prefs.appInstallId.hashCode() % 2 == 0) "A" else "B"
	}

Uh oh!

Year in Review Reading List with A/B Test #6045

Year in Review Reading List with A/B Test #6045

Uh oh!

Conversation

Williamrai commented Oct 24, 2025

What does this do?

Uh oh!

cooltey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Williamrai commented Oct 29, 2025

Uh oh!

cooltey commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Williamrai commented Oct 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

cooltey commented Oct 29, 2025 •

edited

Loading