T402752: Inserting links when editing - no search results#5484
Open
Krystool wants to merge 1 commit intowikimedia:mainfrom
Open
T402752: Inserting links when editing - no search results#5484Krystool wants to merge 1 commit intowikimedia:mainfrom
Krystool wants to merge 1 commit intowikimedia:mainfrom
Conversation
T402752 proposed fix
Krystool
force-pushed
the
T402752_bugfix
branch
from
2090de9 to
8d66d80
Compare
Collaborator
|
Hi @Krystool, thanks for your contribution! I was testing your branch, and I still ran into the same bug - I need to add a space after the term in the search bar to trigger the search. Let me know if I'm missing a step here. T402752.mp4 |
Author
|
Hi @mazevedofs - appreciate you commenting. I'm currently abroad, but I can get back to you on Monday if that's okay. |
Collaborator
|
Hey @Krystool ! I wanted to respond and keep you posted - take all the time you need, enjoy your time abroad! |
Collaborator
|
Hi @Krystool!! Were you able to review my comments? Let us know if you need help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T402752
Notes
I narrowed down the problem which is that the search function doesn't recognize strings of text pulled from the page when editing as non-whitespace text and therefore will not initiate properly unless the user adds something (even just a space), thereby making the function recognise the string as non-whitespace and then working as intended.
(reposted PR as correctly formatted)