New settings view by mazevedofs · Pull Request #5680 · wikimedia/wikipedia-ios

mazevedofs · 2026-02-11T16:38:03Z

Phabricator: https://phabricator.wikimedia.org/T417322

Notes

Rewrite of the settings view and some child views in SwiftUI
The account, search, YiR, notifications and article storage child views were updated

Test Steps

Test all settings items across various themes, languages, devices, and accessibility options
Test settings embedded in the main tab
Make sure we retain all existing functionality
Design review can be done later, there was no offical Figma for this

Screenshots/Videos

…gs view

…ld delegate instace

…o settings-view

…-ios into settings-view

…o settings-view

…-ios into settings-view

… tab bar

…c is embedded in the tab bar, so we use the same actions

tonisevener · 2026-02-11T23:58:02Z

Wikipedia/Code/SettingsCoordinator.swift

+            talkPagePreferencesFooter: WMFLocalizedString("account-talk-preferences-auto-sign-discussions-setting-explanation", value: "Auto-signing of discussions will use the signature defined in Signature settings", comment: "Text explaining how setting the auto-signing of talk page discussions preference works")
+        )
+
+        // Migration: Check if old key exists and migrate to WMFData store


Not sure this area for migrating will work - would they have to open the Search settings for the migration to trigger? Just worried they would lose these settings and behavior until they dig into their Settings again. Maybe we can move it into the launch sequence?

tonisevener · 2026-02-11T23:58:48Z

Wikipedia/Code/ProfileCoordinator.swift

-
+
+    @MainActor
+    private func asyncDismissProfile() async {


I think this is unused.

tonisevener · 2026-02-12T00:01:33Z

Wikipedia/Code/WMFDonateDataControllerWrapper.swift

 import WMFData

-@objc public class WMFDonateDataControllerWrapper: NSObject {
+@objc public class WMFDonateDataControllerWrapper: NSObject { // TODO - delete


tonisevener · 2026-02-12T00:04:35Z

Wikipedia/Code/ProfileCoordinator.swift

    // MARK: - ProfileCoordinatorDelegate Methods

-    public func handleProfileAction(_ action: ProfileAction) {
+    public func handleProfileAction(_ action: ProfileAction) async {


This may not need to be async.

tonisevener · 2026-02-12T00:05:06Z

WMFComponents/Sources/WMFComponents/Components/Profile/WMFProfileView.swift

    private func profileBarItem(item: ProfileListItem) -> some View {
        Button(action: {
-            item.action()
+            Task { @MainActor in


Might be able to revert if asyncDismissProfile is unused.

tonisevener · 2026-02-12T14:37:37Z

WMFComponents/Sources/WMFComponents/Components/Settings/WMFSettingsViewModel.swift

+        await buildSections()
+    }
+
+    private func getMainSection() async -> SettingsSection {


I notice all of the accessory labels don't update when you drill in, change, then tap back.

Tap my languages

Change primary app language

Tap back

My languages label still shows outdated primary app language.

Same goes for Explore feed on/off, Year in Review on/off, and App theme setting.

tonisevener · 2026-02-12T14:39:32Z

WMFComponents/Sources/WMFComponents/Components/Settings/WMFSettingsViewModel.swift

+            item = SettingsItem(
+                image: WMFSFSymbolIcon.for(symbol: .personFilled),
+                color: WMFColor.gray100,
+                title: localizedStrings.accountTitle,


This string should say "Log in" if they are logged out.

tonisevener · 2026-02-12T15:02:24Z

...WMFComponents/Components/Settings/Storage and Syncing/WMFStorageAndSyncingSettingsView.swift

+
+// MARK: - Storage and Syncing Settings View
+
+public struct WMFStorageAndSyncingSettingsView: View {


I notice the old StorageAndSyncingSettingsViewController file is still in the project, can we remove?

tonisevener · 2026-02-12T15:08:37Z

...omponents/Components/Settings/Push Notifications/WMFPushNotificationsSettingsViewModel.swift

+        case .authorized, .provisional, .ephemeral:
+            permissionStatus = .authorized
+            // Load subscription status from UserDefaults
+            isPushEnabled = userDefaults.bool(forKey: "WMFIsSubscribedToEchoNotifications")


(Optional) Maybe let's just set a local immutable property to avoid the same literal string in this file.

private let userDefaultsKey = "WMFIsSubscribedToEchoNotifications"

Bonus would be if we could also migrate this one to the new user defaults store.

tonisevener · 2026-02-12T15:28:03Z

Wikipedia/Code/SettingsViewController.swift

+
+public final class WMFSettingsHostingController: WMFComponentHostingController<WMFSettingsView> {}
+
+@objc final class SettingsViewController: WMFCanvasViewController, WMFNavigationBarConfiguring, Themeable {


Maybe rename so that it's clear in what way this is distinct from the WMFComponents WMFSettingsViewController. I was confused at first.

tonisevener · 2026-02-12T20:22:00Z

Wikipedia/Code/SettingsCoordinator.swift

+
+    // MARK: - About
+    private func tappedAbout() {
+        dismissSettings {


I think About and Help and Feedback pushed on before, now it looks like it's dismissing Settings first before pushing which may be an unexpected change.

tonisevener · 2026-02-12T20:22:45Z

Wikipedia/Code/SettingsCoordinator.swift

+
+    // MARK: - Private methods - Actions
+
+    private func asyncDismissSettings() async {


I don't think this is used.

ankushkushwaha · 2026-03-02T19:35:02Z

Wikipedia/Code/SettingsViewController.swift

+    @objc private func userAuthenticationStateDidChange() {
+        Task { @MainActor [weak self] in
+            guard let self = self else { return }
+
+            let username = self.dataStore?.authenticationManager.authStatePermanentUsername
+            let tempUsername = self.dataStore?.authenticationManager.authStateTemporaryUsername
+            let isTempAccount = WMFTempAccountDataController.shared.primaryWikiHasTempAccountsEnabled &&
+                                self.dataStore?.authenticationManager.authStateIsTemporary == true
+
+            await self.viewModel.updateAuthenticationState(
+                username: username,
+                tempUsername: tempUsername,
+                isTempAccount: isTempAccount
+            )
+
+            updateProfileButton()
+        }
+    }


Suggested change

@objc private func userAuthenticationStateDidChange() {

Task { @MainActor [weak self] in

guard let self = self else { return }

let username = self.dataStore?.authenticationManager.authStatePermanentUsername

let tempUsername = self.dataStore?.authenticationManager.authStateTemporaryUsername

let isTempAccount = WMFTempAccountDataController.shared.primaryWikiHasTempAccountsEnabled &&

self.dataStore?.authenticationManager.authStateIsTemporary == true

await self.viewModel.updateAuthenticationState(

username: username,

tempUsername: tempUsername,

isTempAccount: isTempAccount

)

updateProfileButton()

}

}

@objc private func userAuthenticationStateDidChange() {

let username = dataStore?.authenticationManager.authStatePermanentUsername

let tempUsername = dataStore?.authenticationManager.authStateTemporaryUsername

let isTempAccount =

WMFTempAccountDataController.shared.primaryWikiHasTempAccountsEnabled &&

dataStore?.authenticationManager.authStateIsTemporary == true

Task { @MainActor in

guard let self = self else { return }

await self.viewModel.updateAuthenticationState(

username: username,

tempUsername: tempUsername,

isTempAccount: isTempAccount

)

updateProfileButton()

}

}

ankushkushwaha · 2026-03-02T19:36:39Z

WMF Framework/CommonStrings.swift

+
+    @objc public static let rateTheAppTitle = WMFLocalizedString("main-menu-rate-app", value: "Rate the app", comment: "Button text for showing the app in the app store so user can rate the app")
+
+    @objc public static let helpAndfeedbackTitle = WMFLocalizedString("settings-help-and-feedback", value: "Help and feedback", comment: "Title for showing showing a screen that displays the FAQ and allows users to submit bug reports")


Suggested change

@objc public static let helpAndfeedbackTitle = WMFLocalizedString("settings-help-and-feedback", value: "Help and feedback", comment: "Title for showing showing a screen that displays the FAQ and allows users to submit bug reports")

@objc public static let helpAndfeedbackTitle = WMFLocalizedString("settings-help-and-feedback", value: "Help and feedback", comment: "Title for showing a screen that displays the FAQ and allows users to submit bug reports")

ankushkushwaha · 2026-03-02T19:37:57Z

WMFComponents/Sources/WMFComponents/Components/Settings/Account/WMFAccountSettingsView.swift

+                .listRowSeparator(.hidden)
+
+        case .icon:
+            Text("") // can't break


We can also use EmptyView() for placeholder instead empty text.

mazevedofs added 30 commits July 3, 2025 10:33

Add new view, view model and view controller files for the new settin…

cfb7943

…gs view

Update settings row item

095b518

WIP - move section building to view model, add data controller file

de21308

Adjust view actions and theming

c39898c

Move strings to CommonStrings

e9cf5eb

Add main settings items to view model

bcaae57

Use image instead of string for accessory

ec4201b

Add prop for checking if theme is light

68ca12b

Add new icons for settings

a09f026

Add settings items to view model

ba09115

Add settings delegate to handle actions, update view controller to ho…

794beea

…ld delegate instace

Fix icon themimg

293bdf1

Add temp account case, add dependencies

ec16023

Merge branch 'main' of https://github.com/wikimedia/wikipedia-ios int…

a87ff71

…o settings-view

Make data controller actor

30385b8

YiR Settings item

1a622e3

Add database population

ecacc29

Add external links

f006a1a

add app rating

578aeb6

Merge branch 'main' of https://github.com/wikimedia/wikipedia-ios int…

ebe62e0

…o settings-view

Merge branch 'liquid-glass' of https://github.com/wikimedia/wikipedia…

5bad12f

…-ios into settings-view

Merge branch 'main' of https://github.com/wikimedia/wikipedia-ios int…

af12068

…o settings-view

Add settings actions to coordinator

5c89dee

Add clear cache action

dba9406

Adjust error

ae8774a

Add actions

4954824

Adjust year in review settings toggle

6560474

Add new search settings in WMFComponents

7d0da56

Add notifications settings to WMFComponents

3cab9d7

Adjust settings setup

4557f72

mazevedofs added 13 commits February 10, 2026 12:36

Add article sync settings to WMFComponents

5850047

Add account settings to WMFComponents

3c3e51c

Migrate search settings to WMFData

ada0773

Add correct icons

340ccb7

Merge branch 'liquid-glass' of https://github.com/wikimedia/wikipedia…

229a3fb

…-ios into settings-view

remove test code

15d56e1

Add new SettingsVC class, to allow for tab bar embedding

d124459

Add new SettingsViewController to replace old objc settings vc in the…

9000d76

… tab bar

Add notifications observers and logging

33a0557

Adjust settings view to allow injecting a coordinator when setiings v…

ffb57d2

…c is embedded in the tab bar, so we use the same actions

delete old settings vc

f116355

delete unused files

ab4ab87

Read search preferences from WMFData

e45635f

mazevedofs added the liquid-glass label Feb 11, 2026

remove file ref

5f95fb8

mazevedofs requested a review from tonisevener February 11, 2026 17:31

tonisevener requested changes Feb 12, 2026

View reviewed changes

tonisevener reviewed Feb 12, 2026

View reviewed changes

ankushkushwaha reviewed Mar 2, 2026

View reviewed changes


		// MARK: - Storage and Syncing Settings View

		public struct WMFStorageAndSyncingSettingsView: View {


		public final class WMFSettingsHostingController: WMFComponentHostingController<WMFSettingsView> {}

		@objc final class SettingsViewController: WMFCanvasViewController, WMFNavigationBarConfiguring, Themeable {


		// MARK: - Private methods - Actions

		private func asyncDismissSettings() async {


		@objc public static let rateTheAppTitle = WMFLocalizedString("main-menu-rate-app", value: "Rate the app", comment: "Button text for showing the app in the app store so user can rate the app")

		@objc public static let helpAndfeedbackTitle = WMFLocalizedString("settings-help-and-feedback", value: "Help and feedback", comment: "Title for showing showing a screen that displays the FAQ and allows users to submit bug reports")

Uh oh!

Conversation

mazevedofs commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

Test Steps

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

mazevedofs commented Feb 11, 2026 •

edited

Loading