Skip to content

T321061: Fix picture of the day widget#5702

Merged
tonisevener merged 5 commits intomainfrom
T321061_potd
Feb 27, 2026
Merged

T321061: Fix picture of the day widget#5702
tonisevener merged 5 commits intomainfrom
T321061_potd

Conversation

@l-olson1214
Copy link
Collaborator

@l-olson1214 l-olson1214 commented Feb 25, 2026

Phabricator:
https://phabricator.wikimedia.org/T321061

Notes

Test Steps

  1. Go into WidgetController and replace the fetch with this:
 var components = DateComponents()
        components.year = 2022
        components.month = 11
        components.day = 12
        let hardcodedDate = Calendar.current.date(from: components) ?? Date()
        fetcher.fetchFeaturedContent(forDate: hardcodedDate, siteURL: widgetCache.settings.siteURL, languageCode: widgetCache.settings.languageCode, languageVariantCode: widgetCache.settings.languageVariantCode) { result in

1b. Go into fetchFeaturedContent and set the useCache bool = false
2. Run on various simulators (running the WidgetsExtension)
3. On simulator, press and hold screen until everything jiggles
4. Press edit in upper lefthand corner
5. Add widget
6. Search for Wikipedia
7. Add POTD
8. Ensure it shows + resizes
9. Cry a little because we collectively went down a rabbit hole and it was one tiny change

Screenshots/Videos

Simulator.Screen.Recording.-.iPhone.17.Pro.Max.liquid.glass.-.2026-02-25.at.13.21.36.mov

@l-olson1214 l-olson1214 requested review from a team and tonisevener and removed request for a team February 25, 2026 18:22
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is bringing all the Liquid Glass commits to Main.

If this will be a 7.9.2 version released before LG, please start a new branch from main and cherry-pick the widget commits into it.

Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l-olson1214 The diff looks good but we would still be merging all the liquid glass commits into main (see large commit list), plus one final commit that reverts the liquid glass commits. Let's start a new branch / PR off of main and cherry-pick the widget fix.


var potdTargetImageSize: CGSize {
CGSize(width: 1000, height: 1000)
CGSize(width: 500, height: 500)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace these 500 constants with ImageUtils.ImageWidth.w960.rawValue?

The enum will help us find and test this case in the future if these standards ever change again. The one-off literal integer is what caused me to miss it last time.

This will change the width / height to 960 - I tested on a couple of devices and it still seems to work. I noticed a quality degradation with 500. 960 is the closest standard size to what it was before (1000).

Everything else looks great!

@tonisevener tonisevener dismissed mazevedofs’s stale review February 27, 2026 19:42

This has been fixed.

@tonisevener tonisevener merged commit 4563cf0 into main Feb 27, 2026
4 checks passed
@tonisevener tonisevener deleted the T321061_potd branch February 27, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants