T321061: Fix picture of the day widget#5702
Conversation
mazevedofs
left a comment
There was a problem hiding this comment.
This PR is bringing all the Liquid Glass commits to Main.
If this will be a 7.9.2 version released before LG, please start a new branch from main and cherry-pick the widget commits into it.
There was a problem hiding this comment.
@l-olson1214 The diff looks good but we would still be merging all the liquid glass commits into main (see large commit list), plus one final commit that reverts the liquid glass commits. Let's start a new branch / PR off of main and cherry-pick the widget fix.
78ed8e0 to
bc1de8c
Compare
|
|
||
| var potdTargetImageSize: CGSize { | ||
| CGSize(width: 1000, height: 1000) | ||
| CGSize(width: 500, height: 500) |
There was a problem hiding this comment.
Can you replace these 500 constants with ImageUtils.ImageWidth.w960.rawValue?
The enum will help us find and test this case in the future if these standards ever change again. The one-off literal integer is what caused me to miss it last time.
This will change the width / height to 960 - I tested on a couple of devices and it still seems to work. I noticed a quality degradation with 500. 960 is the closest standard size to what it was before (1000).
Everything else looks great!
Phabricator:
https://phabricator.wikimedia.org/T321061
Notes
Test Steps
1b. Go into fetchFeaturedContent and set the useCache bool = false
2. Run on various simulators (running the WidgetsExtension)
3. On simulator, press and hold screen until everything jiggles
4. Press edit in upper lefthand corner
5. Add widget
6. Search for Wikipedia
7. Add POTD
8. Ensure it shows + resizes
9. Cry a little because we collectively went down a rabbit hole and it was one tiny change
Screenshots/Videos
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.liquid.glass.-.2026-02-25.at.13.21.36.mov