Open
Conversation
tonisevener
requested review from
a team and
mazevedofs
and removed request for
a team
mazevedofs
reviewed
Mar 2, 2026
| if let attributedTitle = titleButton.attributedTitle(for: .normal) { | ||
| let mutAttributedTitle = NSMutableAttributedString(attributedString: attributedTitle) | ||
| mutAttributedTitle.setAttributes([.foregroundColor: theme.colors.link], range: NSRange(location: 0, length: attributedTitle.length)) | ||
| titleButton.setAttributedTitle(mutAttributedTitle, for: .normal) |
Collaborator
There was a problem hiding this comment.
Does this old AutoLayoutSafeMultiLineButton work with the normal tint?
Just for simplicity, highly optional change.
mazevedofs
approved these changes
Mar 2, 2026
Collaborator
mazevedofs
left a comment
mazevedofs
left a comment
There was a problem hiding this comment.
Just have one question, but optional. Looks good to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T416187
Notes
This PR fixes some issues I found while auditing https://phabricator.wikimedia.org/T416187.
I am also preventing navigation bar hiding upon scroll for Settings and in-app web view pages. Hiding felt off to me, because no other bars in the app hide upon scroll aside from Article.
Test Steps
Screenshots/Videos