test: integration tests can now call dynamic libraries#1690
Open
ostylk wants to merge 1 commit intowild-linker:mainfrom
Open
test: integration tests can now call dynamic libraries#1690ostylk wants to merge 1 commit intowild-linker:mainfrom
ostylk wants to merge 1 commit intowild-linker:mainfrom
Conversation
Comment on lines
1
to
3
| // We don't currently run this, we just make sure that we can produce a shared | ||
| // object and that it passes the diff test. | ||
| // |
Member
There was a problem hiding this comment.
You can remove these lines.
| .with_context(|| format!("Invalid Mode `{arg}`"))?; | ||
| if mode == Mode::Dynamic { | ||
| config.assertions.expect_dynamic = true; | ||
| } |
Member
There was a problem hiding this comment.
Currently, specifying //#Mode:dynamic implicitly sets //#RunEnabled:false (introduced in #1033), so I think this needs to be corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1687 .
Using
//#RunDynSym:foothe output binary is treated as a shared library and loaded into the current test process.The function
fooneeds to return an integer and it succeeds if it returns42.Cross compiled libraries cannot be tested that way.
Is there one test in particular where you want to use this feature? I enabled it for
shared.cand calledfoo().