Open
Conversation
willdzeng
requested changes
May 10, 2018
Owner
willdzeng
left a comment
willdzeng
left a comment
There was a problem hiding this comment.
Just a few comments.
Thanks for your contribution
|
|
||
| namespace arti | ||
| { | ||
| namespace arti { |
Owner
There was a problem hiding this comment.
Can you run clang-format on this file with the config .clang-format in the repository so that I can see the diff?
Thanks.
| # set(CMAKE_CXX_FLAGS "-std=c++0x ${CMAKE_CXX_FLAGS}") | ||
|
|
||
| # find_package(Eigen3 REQUIRED) | ||
| find_package(Eigen3 REQUIRED) |
Owner
There was a problem hiding this comment.
you might need to add eigen in .travis.yml file for the build to pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I have added some changes to your code. It can now read the SNxxx.conf file and based on that create undistortion mappings. These mappings are then used to rectify the image and publish them.