fix(XYChart, Network): Preserve passed onMouseLeave and onMouseMove#195
Open
williaster wants to merge 3 commits intomasterfrom
Open
fix(XYChart, Network): Preserve passed onMouseLeave and onMouseMove#195williaster wants to merge 3 commits intomasterfrom
williaster wants to merge 3 commits intomasterfrom
Conversation
added 3 commits
December 17, 2019 16:49
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 80.47% 80.49% +0.01%
==========================================
Files 109 109
Lines 2433 2435 +2
Branches 571 573 +2
==========================================
+ Hits 1958 1960 +2
Misses 291 291
Partials 184 184
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Currently if a user of
XYChartorNetworkpasses their ownonMouseLeaveoronMouseMoveprops in addition to arenderTooltipprop, the mouse handlers are overwritten by theWithTooltipprovided mouse handlers and never invoked.This PR fixes this by
@data-ui/sharedsWithTooltipto acceptonMouseLeaveandonMouseMovefunctions, which are invoked when the provided equivalents are called.XYChartandNetworkto pass along the user-providedonMouseLeaveandonMouseMovetoWithTooltipTest plan
WithTooltip