fix: add history directly viewable in folder/group viewer #7365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add database tables for folder_permission_history and group_permission_history - Track permission changes in folders (add/remove owner, update permissions) - Track permission changes in groups (add/remove member, update summary) - Track permission changes via granular ACL endpoints - Add API endpoints to retrieve permission history - GET /api/w/:workspace/folders_history/get/:name (folder admins only) - GET /api/w/:workspace/groups_history/get/:name (workspace admins only) - Simplified schema without before_state, after_state, or change_description fields Co-authored-by: Ruben Fiszel <rubenfiszel@users.noreply.github.com>
- Add OpenAPI endpoints for folder and group permission history - Create reusable PermissionHistory component with Svelte 5 - Integrate history display into FolderEditor (for folder admins) - Integrate history display into GroupEditor (for workspace admins) - Fix ownership issues in folders.rs and granular_acls.rs - Frontend validation passes (npm run check) Note: SQLx query cache update required (cargo sqlx prepare) Co-authored-by: Ruben Fiszel <rubenfiszel@users.noreply.github.com>
devdattatalele
requested review from
alpetric,
hugocasa and
rubenfiszel
as code owners
rubenfiszel
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.