refactor: move x509 signature key creation to e2e-identity, part 2 #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need it with the new CC10 API.
The only enrollment available now is the one where the client ID is explicitly specified.
These make no sense now since we're not doing activation anymore.
It is now unused.
istankovic
force-pushed
the
ivan/move-e2ei-sigkey-creation-to-e2ei
branch
2 times, most recently
from
5c76d04 to
10dcd6b
Compare
We're not going to be needing those.
istankovic
force-pushed
the
ivan/move-e2ei-sigkey-creation-to-e2ei
branch
from
10dcd6b to
7e6fa61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1834, this is part 2 of moving x509 signature key generation from crypto to e2e-identity.
Here we remove the so-called activation enrollment, which takes the existing client ID and assumes that we're switching from a basic credential to x509. That leaves us with just one enrollment type, where we don't assume anything and require the caller to specify the client ID to be used for the certificate. We also remove the stash and pop functionality since that is going to be handled internally by the acquisition type.