Skip to content

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Oct 28, 2025

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann changed the title effect and interpreter for update WPB-20055 Endpoint for updating user group with SCIM Oct 28, 2025
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 28, 2025
@eyeinsky eyeinsky force-pushed the ml/WPB-20054-scim-get-group branch from 79f0bf6 to f089d1d Compare October 30, 2025 17:11
@eyeinsky eyeinsky force-pushed the ml/WPB-20054-scim-get-group branch 2 times, most recently from bf8958c to 15ff839 Compare November 7, 2025 13:55
@fisx fisx force-pushed the WPB-20055-end-point-for-updating-user-group-with-scim branch from 7809e2e to 5179609 Compare November 10, 2025 13:18
@eyeinsky eyeinsky force-pushed the ml/WPB-20054-scim-get-group branch from 15ff839 to b241770 Compare November 10, 2025 13:19
@fisx fisx force-pushed the WPB-20055-end-point-for-updating-user-group-with-scim branch from 5179609 to 1fd90ff Compare November 10, 2025 13:51
@eyeinsky eyeinsky force-pushed the ml/WPB-20054-scim-get-group branch 3 times, most recently from 479d19e to a81d162 Compare November 10, 2025 15:28
@fisx fisx force-pushed the ml/WPB-20054-scim-get-group branch from 0b04971 to e93e1a8 Compare November 11, 2025 08:32
@fisx fisx force-pushed the WPB-20055-end-point-for-updating-user-group-with-scim branch from 1fd90ff to 5d74210 Compare November 11, 2025 08:39
@fisx fisx added not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR and removed ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist labels Nov 12, 2025
@fisx fisx marked this pull request as ready for review November 12, 2025 16:28
@fisx fisx requested review from a team as code owners November 12, 2025 16:28
Base automatically changed from ml/WPB-20054-scim-get-group to develop November 12, 2025 16:54
@fisx fisx force-pushed the WPB-20055-end-point-for-updating-user-group-with-scim branch from 35ab411 to 74a33ab Compare November 13, 2025 07:56
@battermann battermann removed the not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR label Nov 13, 2025
@battermann battermann requested a review from Copilot November 13, 2025 08:49
Copilot finished reviewing on behalf of battermann November 13, 2025 08:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements SCIM support for updating user groups (WPB-20055), enabling group name changes and member list modifications through the SCIM API endpoint.

Key Changes:

  • Implements putGroup in the SCIM Group API to handle group updates via SCIM
  • Adds new internal Brig endpoints for creating and updating user groups with enhanced error handling
  • Refactors existing CreateGroupFull and GetGroupUnsafe operations to CreateGroupInternal and GetGroupInternal for naming consistency

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
services/spar/src/Spar/Scim/Group.hs Implements putGroup method by calling scimUpdateUserGroup
services/spar/src/Spar/Error.hs Updates error mapping for SCIM subsystem errors, refines error messages for invalid members
services/brig/src/Brig/API/Internal.hs Adds updateGroupInternalH handler and renames create/get group handlers for consistency
libs/wire-subsystems/src/Wire/ScimSubsystem.hs Adds ScimUpdateUserGroup operation to subsystem interface
libs/wire-subsystems/src/Wire/ScimSubsystem/Interpreter.hs Implements scimUpdateUserGroupImpl with validation for team membership and SCIM management
libs/wire-subsystems/src/Wire/UserGroupSubsystem.hs Adds internal operations: CreateGroupInternal, GetGroupInternal, ResetUserGroupInternal
libs/wire-subsystems/src/Wire/UserGroupSubsystem/Interpreter.hs Implements access control bypass for internal operations and resetUserGroupInternal
libs/wire-subsystems/src/Wire/BrigAPIAccess.hs Updates API interface with new internal group operations and error handling
libs/wire-subsystems/src/Wire/BrigAPIAccess/Rpc.hs Implements RPC calls for internal group operations with proper error handling
libs/wire-api/src/Wire/API/Routes/Internal/Brig.hs Defines UpdateGroupInternalRequest type and API route for group updates
libs/wire-subsystems/test/unit/Wire/ScimSubsystem/InterpreterSpec.hs Updates mock to align with renamed operations
integration/test/Test/Spar.hs Adds comprehensive integration tests for SCIM group update and validation scenarios
integration/test/API/Spar.hs Adds updateScimUserGroup test helper function
changelog.d/2-features/update-scim-groups Documents the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 13, 2025
@battermann battermann merged commit e735b17 into develop Nov 13, 2025
10 checks passed
@battermann battermann deleted the WPB-20055-end-point-for-updating-user-group-with-scim branch November 13, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants