WPB-20054 SCIM get group #4831
Merged
WPB-20054 SCIM get group #4831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
fisx
force-pushed
the
WPB-20053-scim-groups-create-2
branch
from
749ed7b to
b8db0dd
Compare
blackheaven
force-pushed
the
WPB-20053-scim-groups-create-2
branch
from
277dac2 to
638da63
Compare
eyeinsky
force-pushed
the
WPB-20053-scim-groups-create-2
branch
3 times, most recently
from
42d669b to
797766b
Compare
eyeinsky
force-pushed
the
ml/WPB-20054-scim-get-group
branch
2 times, most recently
from
bf8958c to
15ff839
Compare
fisx
force-pushed
the
WPB-20053-scim-groups-create-2
branch
2 times, most recently
from
c5929df to
69310c6
Compare
eyeinsky
force-pushed
the
ml/WPB-20054-scim-get-group
branch
4 times, most recently
from
479d19e to
a81d162
Compare
fisx
changed the base branch from
WPB-20053-scim-groups-create-2
to
WPB-20053-scim-groups-create-3
fisx
approved these changes
Nov 11, 2025
- add `newUserGroup` helper to skip repeating `mempty` - in hscim.cabal, fix readme link and source-repository subdir
fisx
force-pushed
the
ml/WPB-20054-scim-get-group
branch
from
0b04971 to
e93e1a8
Compare
eyeinsky
commented
Nov 11, 2025
| CreateGroup creator newGroup -> createUserGroup creator newGroup | ||
| CreateGroupFull managedBy team mbCreator newGroup -> createUserGroupFullImpl managedBy team mbCreator newGroup | ||
| GetGroup getter gid includeChannels -> getUserGroup getter gid includeChannels | ||
| GetGroupUnsafe tid gid includeChannels -> getUserGroupUnsafe tid gid includeChannels |
Collaborator
Author
There was a problem hiding this comment.
Just to check, is the reason to call this unsafe because we don't know nor check if the group is part of the team?
Contributor
There was a problem hiding this comment.
i think team membership is guaranteed because of the database schema, but GetGroup also does access control checks: who's asking, and which users are they allowed to see in the member list?
Collaborator
Author
|
Apparently, I can't approve it as I created this PR, nevertheless I approve! :) |
This was referenced Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d