textField - a11y label improvements #3883
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seMemo hook usage
yotam-wix
requested review from
lidord-wix
and removed request for
lidord-wix
lidord-wix
reviewed
Dec 23, 2025
Collaborator
lidord-wix
left a comment
lidord-wix
left a comment
There was a problem hiding this comment.
Added some comments
BTW, the decision of the reading order is made by the UX?
Comment on lines
+156
to
+158
| } else if (placeholder) { | ||
| parts.push(placeholder); | ||
| } |
Collaborator
There was a problem hiding this comment.
Have we decided to include the placeholder? it can also be some weird example..
Collaborator
Author
There was a problem hiding this comment.
That's what Alexey said in the case helper text is empty :|
| parts.push(`you can enter up to ${others.maxLength} characters`); | ||
| } | ||
|
|
||
| return parts.join(', '); |
Collaborator
There was a problem hiding this comment.
Seems like it will work, for English :)
What about other languages?
Collaborator
Author
There was a problem hiding this comment.
Should I use i18n? Do I need to change something with the reading order of the label in other languages?
Co-authored-by: Lidor Dafna <66782556+lidord-wix@users.noreply.github.com>
Collaborator
Author
that was discussed with Alexey and Naama and that's what Alexey said in the end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
textField - added better handling of textField a11y label. Added unification of all different parts of the component (Label, helperText, charCounter), ordered by a11y guidelines given.
Changelog
textField - a11y label fix.
Additional info
MADS-4797