-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Usermod bus type #4123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Usermod bus type #4123
Conversation
BusUsermod - virtual bus to be used by usermods UsermodBus - base class for usermods that implement a bus based on BusUsermod
…with I2C PSPWM firmware
|
maintainers call for discussion: i think we should first understand if an "adding a bus by usermod" feature still fits to our future view of the WLED architecture. |
|
Since I'm no longer one of the WLED development team members I'll try to explain why I thought this was a good idea at the time. Bus architecture is IMO good and flexible (though it could be better still) so adding a user extensible bus seemed nice addition to allow (advanced) users to extend output to devices of not necessarily LED type. |
|
As the one who started this PR originally, despite not being involved in anything WLED related for the past year, I'm still convinced that it is useful for advanced users (as @blazoncek wrote). There are many exotic use cases out there, that one could cover using WLED with minor additions. The project I was involved in 2024 required a way to control 'polarity change christmas lights', that typically run on 31V "AC". I got that working by writing a phase shift pwm firmware for AT8870 motor shields, and controlling those from WLED via I2C. The same modified motor shields also work perfectly to control 12V-36V RGBW strips. So it's certainly not for the average user, but I was glad to have that possibility back then. |
|
Any modular approach needs to support multiple types, not just one. |
PR regarding bus implementations as usermods, as discussed with @blazoncek