-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add support for Australian Western Time #5273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change adds support for Australian Western Standard Time (AWST, Perth timezone) by introducing a new timezone definition with UTC+8 offset and no daylight saving time, alongside corresponding UI updates to the timezone selector. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (4)wled00/data/**/*.{htm,html,css,js}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
wled00/data/**📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
wled00/data/settings*.htm📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
wled00/**/*.cpp📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
thanks, this seems pretty straight forward. |
|
https://en.wikipedia.org/wiki/2009_Western_Australian_daylight_saving_referendum After a 3 yr trial it was put to a compulsory referendum in 2009 and rejected 55% to 45%. The Premier at the time declared "it should not be considered for another 20 years". |
|
ah, I thought you meant an attempt in adding this code :) |
Western Australia doesn't currently have DST - it was trialed in the past and abandoned
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.