Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for issuing io_uring cancellation requests against a condy::Runtime from outside the owning runtime thread, and introduces tests to exercise cancellation both cross-task and cross-thread.
Changes:
- Add
WorkType::Canceland route cancellation requests through msg_ring when invoked from another runtime/thread. - Introduce
Runtime::cancel(void*)and internal helpers to prepare cancel SQEs. - Update
Channelcancel paths to deferresume_work()until the scheduled handle runs, and add new runtime cancellation tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tests/test_runtime.cpp | Adds tests for cancellation from another task and from another thread. |
| include/condy/work_type.hpp | Adds WorkType::Cancel tag for pointer-encoded work dispatch. |
| include/condy/runtime.hpp | Implements cross-thread/cross-runtime cancellation via msg_ring + Cancel work dispatch. |
| include/condy/channel.hpp | Adjusts cancellation scheduling so pending-work accounting is resumed at invocation time. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.