Fixes and tests for async and crypto callbacks#9784
Open
dgarske wants to merge 3 commits intowolfSSL:masterfrom
Open
Fixes and tests for async and crypto callbacks#9784dgarske wants to merge 3 commits intowolfSSL:masterfrom
dgarske wants to merge 3 commits intowolfSSL:masterfrom
Conversation
dgarske
force-pushed
the
async_cryptocb
branch
from
71f9210 to
7f50626
Compare
Contributor
|
This appears to update only the examples and the workflow. How does this solve the ZD ticket @dgarske ? |
Contributor
Author
Thanks for your interest in my work @padelsbach ... it doesn't solve it yet. I'm still working with the customer. |
dgarske
force-pushed
the
async_cryptocb
branch
from
7f50626 to
0dffc8a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves async + crypto-callback behavior and strengthens the async examples/CI coverage for both software async and crypto-callback simulated pending flows.
Changes:
- Fix/clarify async pending handling for crypto/PK callbacks and clear stale async device state after popping events.
- Update async examples to support
ASYNC_MODE(sw vs cryptocb), including registration of crypto callbacks and updated docs. - Extend GitHub Actions to build/run async examples in both modes.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| wolfcrypt/src/cryptocb.c | Fix %p logging by casting ctx pointers to void*. |
| wolfcrypt/src/async.c | Document callback-driven pending/retry behavior in the polling loop. |
| src/internal.c | Clear stale async event state after event removal to enable clean retries. |
| examples/async/user_settings.h | Adjust example settings and document mutually exclusive async modes. |
| examples/async/async_tls.c | Update include flow for user settings; narrow simulated pending operations in callback. |
| examples/async/async_server.c | Register/unregister crypto callback device and improve error logging. |
| examples/async/async_client.c | Register/unregister crypto callback device and improve error logging. |
| examples/async/README.md | Document build modes and how to run async examples. |
| examples/async/Makefile | Add ASYNC_MODE switch controlling WOLFSSL_ASYNC_CRYPT_SW vs WOLF_CRYPTO_CB. |
| .github/workflows/async-examples.yml | Build/run CI matrix for both async modes and adjust pending-count validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes and tests for async and crypto callbacks
Fixes ZD 21071
Testing
How did you test?
Checklist