Skip to content

FIPS 205, SLH-DSA: implementation#9838

Open
SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
SparkiDev:slhdsa_1
Open

FIPS 205, SLH-DSA: implementation#9838
SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
SparkiDev:slhdsa_1

Conversation

@SparkiDev
Copy link
Contributor

Description

Adding implementation of SLH-DSA.
Some tests added.

Testing

Regression tested SLH-DSA including:
--enable-slhdsa
--enable-slhdsa=yes,verify-only
--enable-slhdsa=yes,small
--enable-intelasm

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Feb 27, 2026
@SparkiDev SparkiDev force-pushed the slhdsa_1 branch 5 times, most recently from af2fa59 to 4d541e7 Compare February 27, 2026 03:32
@SparkiDev
Copy link
Contributor Author

retest this please

@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Feb 27, 2026
@SparkiDev SparkiDev assigned SparkiDev and unassigned wolfSSL-Bot Mar 2, 2026
@SparkiDev SparkiDev removed the request for review from wolfSSL-Bot March 2, 2026 23:08
@SparkiDev SparkiDev force-pushed the slhdsa_1 branch 2 times, most recently from 0d6a066 to d8ac9da Compare March 3, 2026 03:37
@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Mar 3, 2026
@SparkiDev SparkiDev requested a review from wolfSSL-Bot March 3, 2026 04:16
@JacobBarthelmeh JacobBarthelmeh requested a review from Copilot March 3, 2026 23:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial SLH-DSA (FIPS 205) support to wolfCrypt, wiring it into build systems, benchmarks, and both unit/API tests.

Changes:

  • Introduces the SLH-DSA public API header and integrates SLH-DSA into core build/packaging (autotools/CMake) and CI configs.
  • Adds SLH-DSA coverage to wolfcrypt test runner plus dedicated API unit tests.
  • Adds SLH-DSA benchmark support and extends SHA3 AVX2 assembly gating for SLH-DSA builds.

Reviewed changes

Copilot reviewed 17 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
wolfssl/wolfcrypt/wc_slhdsa.h New public SLH-DSA API header, parameter constants, key struct and function prototypes.
wolfssl/wolfcrypt/types.h Adds DYNAMIC_TYPE_SLHDSA for memory tracking.
wolfssl/wolfcrypt/include.am Installs the new wc_slhdsa.h header.
wolfcrypt/test/test.h Declares slhdsa_test() for the wolfcrypt test runner.
wolfcrypt/test/test.c Hooks SLH-DSA into test execution and adds SLH-DSA test vectors / sign-verify tests.
wolfcrypt/src/sha3_asm.S Enables SHA3 AVX2 multi-block symbols when SLH-DSA is enabled.
wolfcrypt/src/poly1305_asm.asm Comment header formatting change.
wolfcrypt/src/chacha_asm.asm Comment header formatting change.
wolfcrypt/src/aes_xts_asm.asm Comment header formatting change.
wolfcrypt/src/aes_gcm_asm.asm Comment header formatting change.
wolfcrypt/benchmark/benchmark.h Adds SLH-DSA benchmark prototype.
wolfcrypt/benchmark/benchmark.c Adds SLH-DSA benchmark flags/CLI options and implements bench_slhdsa().
tests/api/test_slhdsa.h New API test declarations for SLH-DSA.
tests/api/test_slhdsa.c New API unit tests for init, sizing, keygen, sign/verify, hash-signing, import/export, checkkey.
tests/api/include.am Adds SLH-DSA API tests to automake build and dist.
tests/api.c Registers SLH-DSA API tests in the test case list.
src/include.am Adds wolfcrypt/src/wc_slhdsa.c to library sources under BUILD_WC_SLHDSA.
configure.ac Adds --enable-slhdsa handling, flags, and BUILD_WC_SLHDSA conditional.
CMakeLists.txt Adds CMake option for WOLFSSL_HAVE_SLHDSA and includes SLH-DSA API test source.
.wolfssl_known_macro_extras Adds SLH-DSA-related macro names to the known-macro list.
.github/workflows/pq-all.yml Enables SLH-DSA in PQ CI matrix configurations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Adding implementation of SLH-DSA.
Included optimizations for Intel x64.
Some tests added.
@SparkiDev
Copy link
Contributor Author

retest this please

@SparkiDev SparkiDev added the For This Release Release version 5.9.0 label Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants