Open
Conversation
af2fa59 to
4d541e7
Compare
Contributor
Author
|
retest this please |
0d6a066 to
d8ac9da
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial SLH-DSA (FIPS 205) support to wolfCrypt, wiring it into build systems, benchmarks, and both unit/API tests.
Changes:
- Introduces the SLH-DSA public API header and integrates SLH-DSA into core build/packaging (autotools/CMake) and CI configs.
- Adds SLH-DSA coverage to wolfcrypt test runner plus dedicated API unit tests.
- Adds SLH-DSA benchmark support and extends SHA3 AVX2 assembly gating for SLH-DSA builds.
Reviewed changes
Copilot reviewed 17 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| wolfssl/wolfcrypt/wc_slhdsa.h | New public SLH-DSA API header, parameter constants, key struct and function prototypes. |
| wolfssl/wolfcrypt/types.h | Adds DYNAMIC_TYPE_SLHDSA for memory tracking. |
| wolfssl/wolfcrypt/include.am | Installs the new wc_slhdsa.h header. |
| wolfcrypt/test/test.h | Declares slhdsa_test() for the wolfcrypt test runner. |
| wolfcrypt/test/test.c | Hooks SLH-DSA into test execution and adds SLH-DSA test vectors / sign-verify tests. |
| wolfcrypt/src/sha3_asm.S | Enables SHA3 AVX2 multi-block symbols when SLH-DSA is enabled. |
| wolfcrypt/src/poly1305_asm.asm | Comment header formatting change. |
| wolfcrypt/src/chacha_asm.asm | Comment header formatting change. |
| wolfcrypt/src/aes_xts_asm.asm | Comment header formatting change. |
| wolfcrypt/src/aes_gcm_asm.asm | Comment header formatting change. |
| wolfcrypt/benchmark/benchmark.h | Adds SLH-DSA benchmark prototype. |
| wolfcrypt/benchmark/benchmark.c | Adds SLH-DSA benchmark flags/CLI options and implements bench_slhdsa(). |
| tests/api/test_slhdsa.h | New API test declarations for SLH-DSA. |
| tests/api/test_slhdsa.c | New API unit tests for init, sizing, keygen, sign/verify, hash-signing, import/export, checkkey. |
| tests/api/include.am | Adds SLH-DSA API tests to automake build and dist. |
| tests/api.c | Registers SLH-DSA API tests in the test case list. |
| src/include.am | Adds wolfcrypt/src/wc_slhdsa.c to library sources under BUILD_WC_SLHDSA. |
| configure.ac | Adds --enable-slhdsa handling, flags, and BUILD_WC_SLHDSA conditional. |
| CMakeLists.txt | Adds CMake option for WOLFSSL_HAVE_SLHDSA and includes SLH-DSA API test source. |
| .wolfssl_known_macro_extras | Adds SLH-DSA-related macro names to the known-macro list. |
| .github/workflows/pq-all.yml | Enables SLH-DSA in PQ CI matrix configurations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adding implementation of SLH-DSA. Included optimizations for Intel x64. Some tests added.
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding implementation of SLH-DSA.
Some tests added.
Testing
Regression tested SLH-DSA including:
--enable-slhdsa
--enable-slhdsa=yes,verify-only
--enable-slhdsa=yes,small
--enable-intelasm
Checklist