additional sanity check with session ticket size#9858
Merged
douzzer merged 2 commits intowolfSSL:masterfrom Mar 5, 2026
Merged
additional sanity check with session ticket size#9858douzzer merged 2 commits intowolfSSL:masterfrom
douzzer merged 2 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an additional bounds check when parsing/decrypting TLS 1.2 session tickets to ensure the encrypted-length field cannot exceed the actual received ticket buffer size, and introduces a regression test that tampers with enc_len to validate the sanity check.
Changes:
- Add a length validation in
DoDecryptTicket()to reject tickets whereenc_len + fixed_overhead > total_ticket_len. - Add a TLS 1.2 memio regression test that generates a valid ticket, corrupts
enc_len, and attempts resumption.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/api.c |
Adds test_ticket_enc_corrupted to exercise corrupted enc_len handling during TLS 1.2 ticket resumption. |
src/internal.c |
Adds a sanity check preventing out-of-bounds access when enc_len exceeds the available ticket buffer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
douzzer
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZD21281