[Build] Clean Up mediapicker Local Build Substitutions#15243
Merged
Conversation
Remove unused gradle extension properties for mediapicker dependencies that are no longer used in the project: - mediaPickerDomainBinaryPath - mediaPickerSourceDeviceBinaryPath - mediaPickerSourceGifBinaryPath Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add mediaPickerSourceCameraBinaryPath to include_builds.gradle for local development substitution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up unused Media Picker local-build substitution settings and ensures the camera source module is correctly wired for local development. It specifically aligns Gradle configuration with the subset of Media Picker modules actually used by the app, avoiding future misconfigurations around deprecated GIF support.
Changes:
- Removed unused Gradle
extproperties formediapickerdomain, source-device, and source-gif binaries fromsettings.gradle. - Ensured only the
mediapickercore andsource-camerabinary coordinates are defined as Gradleextproperties. - Updated
include_builds.gradleto substitute thesource-cameramodule when using a local Media Picker build, matching the existingimplementationdependency inWooCommerce/build.gradle.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
settings.gradle |
Removes unused Media Picker binary path properties and keeps only the core and source-camera module coordinates, which are the ones actually used. |
config/gradle/include_builds.gradle |
Updates the local-build substitution to include the source-camera project alongside the main mediapicker project, so local Media Picker builds correctly replace both binary dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
wzieba
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Partially) Closes: AINFRA-1781
Description
Remove unused
mediapickerpath configurations and add the missingsource-camerasubstitution for local development builds.Context: The Tenor API is being sunset on June 30, 2026. The
source-gifmodule in theMedia Pickerlibrary relies on Tenor for GIF search functionality. Since this project doesn't use thesource-gifmodule (orsource-deviceanddomain), we're removing these unused dependency substitution configurations to avoid misconfiguration, or using the (to be) deprecatedsource-gifmodule.Changes:
mediaPickerDomainBinaryPathmediaPickerSourceDeviceBinaryPathmediaPickerSourceGifBinaryPathmediaPickerSourceCameraBinaryPathsubstitution toinclude_builds.gradle.Test Steps
Normal Builds
Choose from deviceTake a photoWordPress media libraryLocal Builds
local-builds.gradlefile withlocalMediaPickerPathpointing to a localMedia Pickercheckout.FYI: OnMedia Picker, you will need to updateagpVersionversion to8.13.2and match the AGP version of WCAndroid.Choose from deviceTake a photoWordPress media libraryRELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.