Feat: Adding timestamp-based report expiration feature #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes - add omitted contracts, README.md fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes according to audit comments - are as follows:
src/testand especially the unit test script for feed contract insrc/test/feed/unit/DataStreamsFeedTest.t.solTruncatedReportstruct on the use of uint32 for timestamps has a long-term overflow risk ("Y2106 bug") - and it is an accepted trade-offPS. Note that switching from
abi.encodeWithSelectortoabi.encodeCalland putting the arguments in a tuple was already merged in the previous PR along with other slight improvements.