fix: TanStack Start friction log fixes for middleware and doctor checks#77
Open
fix: TanStack Start friction log fixes for middleware and doctor checks#77
Conversation
…confusion The installer agent could confuse TanStack Router's createRouter() with TanStack Start's server middleware config, instructing users to add authkitMiddleware to router.tsx instead of start.ts. Added explicit warning in SKILL.md and improved doctor check remediation with the correct code pattern.
…utes in src/ and app/ Previously only checked flat routes in src/ and nested routes in app/, causing false CALLBACK_ROUTE_MISSING errors for TanStack Start projects using nested routes in src/ (e.g. src/routes/api/auth/callback.tsx).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createRouter()(client-side) withstart.tsserver middlewareMISSING_AUTHKIT_MIDDLEWAREremediation to include exact code patternCALLBACK_ROUTE_MISSINGfalse positive by checking both flat and nested route conventions in bothsrc/andapp/directoriesWhy
Friction log from a TanStack Start user reported two issues:
createRouter({ middleware: [...] })inapp.tsxinstead of the correctcreateStart({ requestMiddleware: [...] })instart.tsworkos doctorreportedCALLBACK_ROUTE_MISSINGeven though the callback route existed — the check only looked for flat routes insrc/and nested routes inapp/, missing the other two combinationsNotes
createStart+requestMiddleware)