Add reforge optimizer setting for Hit/Expertise preference #1222
+31
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of to expertise when both options are present. Enable this by default for all mage specs
|
Can we not bake this into the reforger itself instead of making it a boolean? Just checking for all caster specs (but then in JS) |
- Removed preferHitOverExpertise boolean parameter from ReforgeOptimizer - Replaced with automatic caster spec detection - Casters (Mage, Warlock, Priest, Balance/Resto Druid, Ele/Resto Shaman, Holy Paladin, Mistweaver Monk) now automatically prefer Hit over Expertise - Removed preferHitOverExpertise: true from all mage spec UIs
Saji-Saji
force-pushed
the
prefer-hit-reforge
branch
from
f3100e8 to
ceb6b53
Compare
Author
Baked in for all caster specs, Hesitant if we should do this for Holy Paladin or Mistweaver, as they may want to actually use expertise at times? We don't exactly support it, but someone may be using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new option to the
ReforgeOptimizerthat allows caster classes to prefer Hit Rating over Expertise Rating when suggesting reforges. This helps ensure that, when both stats are available as reforging options, Hit is prioritized, which is more relevant for caster classes. The option is enabled by default for all Mage specializations. Additionally, this seems to make reforging decisions faster when enabled for casters as it removes possible options.Key changes:
Reforge logic improvements:
preferHitOverExpertiseoption toReforgeOptimizerOptionsand implemented logic inReforgeOptimizerto filter out Expertise reforges in favor of Hit reforges for items that don't natively have either stat. [1] [2] [3] [4]Mage specialization updates:
preferHitOverExpertiseoption by default for Arcane, Fire, and Frost Mage simulation UIs to improve reforge suggestions for caster gear. [1] [2] [3]