Skip to content

Fix Channeling breaking ReactToEvent #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1337LutZ merged 1 commit into from
Dec 21, 2025
Merged

Fix Channeling breaking ReactToEvent #1251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sim/common/mop/trinkets_phase_3_52.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,10 +525,6 @@ func init() {
)
// Manually override Crit % to Crit Rating
statBuffAura.BuffedStatTypes = []stats.Stat{stats.CritRating}
// @TODO: Disabled for now as this seems to break UVLS interactions
// statBuffAura.Aura.ApplyOnGain(func(aura *core.Aura, sim *core.Simulation) {
// character.ReactToEvent(sim, false)
// })

triggerAura := character.MakeProcTriggerAura(core.ProcTrigger{
Name: fmt.Sprintf("%s (%s)", label, versionLabel),
Expand All @@ -543,6 +539,7 @@ func init() {
RequireDamageDealt: true,
Handler: func(sim *core.Simulation, spell *core.Spell, _ *core.SpellResult) {
statBuffAura.Activate(sim)
character.ReactToEvent(sim, false)
},
})

Expand Down
6 changes: 6 additions & 0 deletions sim/core/gcd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ func (unit *Unit) SetRotationTimer(sim *Simulation, rotationReadyAt time.Duratio

// Call this when reacting to events that occur before the next scheduled rotation action
func (unit *Unit) ReactToEvent(sim *Simulation, randomizeReactionTime bool) {
// If you are channeling return early because channeling has it's own
// interrupt handling.
if unit.IsChanneling() {
return
}

// If the next rotation action was already scheduled for this timestep then execute it now
unit.Rotation.DoNextAction(sim)

Expand Down
Loading