add endpoint for running series of sims #393
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duneus
commented
Jul 1, 2025
| const { stdout } = await execAsync('go env GOROOT'); | ||
| const GO_ROOT = stdout.replace('\n', ''); | ||
| const wasmExecutablePath = path.join(GO_ROOT, '/misc/wasm/wasm_exec.js'); | ||
| const wasmExecutablePath = path.join(GO_ROOT, '/lib/wasm/wasm_exec.js'); |
Author
There was a problem hiding this comment.
oh yeah, this path was changed at some point in the attributable, had to patch this or it wouldn't work locally, I guess it's irrelevant
There was a problem hiding this comment.
this would actually be good to update, since this has been a proper path to wasm-exec.js for a while now.
There was a problem hiding this comment.
I just implemented a change that was merged into master supporting the go 1.24 change where they moved this. Don't forget to merge in the latest changes to your fork
Duneus
force-pushed
the
add-chart-sim-handler
branch
from
4313933 to
b764917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint added by this PR allows for running a suite of sims that are identical besides the adjusted stats.
Current implementation lets you specify which stats you want to compare, what is the increment by which each sim should change the value of both stats and what are the upper and lower bounds for the comparison. The output can later be put into a neat graphical form.