Skip to content

Add zip extension to unit test PHP setup#215

Merged
swissspidy merged 2 commits intomainfrom
copilot/install-zip-extension-for-tests
Mar 3, 2026
Merged

Add zip extension to unit test PHP setup#215
swissspidy merged 2 commits intomainfrom
copilot/install-zip-extension-for-tests

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

The zip extension was configured in setup-php for functional tests but omitted from the unit test step, causing an inconsistency.

Change

  • Added extensions: zip to the setup-php step in the unit tests job of reusable-testing.yml
- name: Set up PHP environment
  uses: shivammathur/setup-php@...
  with:
    php-version: '${{ matrix.php }}'
    ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
    extensions: zip   # was missing
    coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
    tools: composer,cs2pr

Functional tests already include zip (alongside gd, imagick, mysql, pdo_sqlite).

Original prompt

This section details on the original issue you should resolve

<issue_title>Install zip extension</issue_title>
<issue_description> the zip extension is included in setup-php for functional tests but missing for unit tests in reusable-testing.yml.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add zip extension for unit tests in reusable-testing.yml Add zip extension to unit test PHP setup Mar 3, 2026
@swissspidy swissspidy marked this pull request as ready for review March 3, 2026 22:47
@swissspidy swissspidy requested a review from a team as a code owner March 3, 2026 22:47
Copilot AI review requested due to automatic review settings March 3, 2026 22:47
@swissspidy swissspidy merged commit 8304d6e into main Mar 3, 2026
13 checks passed
@swissspidy swissspidy deleted the copilot/install-zip-extension-for-tests branch March 3, 2026 22:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the unit test PHP environment with the functional test setup by ensuring the zip PHP extension is installed during unit test runs, removing an inconsistency in CI configuration.

Changes:

  • Add extensions: zip to the shivammathur/setup-php step in the unit tests job within the reusable testing workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request scope:testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install zip extension

3 participants