Revert "Add workflow to detect commands missing in readme"#217
Revert "Add workflow to detect commands missing in readme"#217swissspidy merged 1 commit intomainfrom
Conversation
This reverts commit 8e439f1.
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously added workflow step that compared documented commands to registered WP-CLI commands, due to false positives in packages that register commands under other roots.
Changes:
- Removes the “documented vs registered commands” verification step from the README regeneration workflow.
- Updates the git author configuration used for automated commits created by the workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| - name: Configure git user | ||
| run: | | ||
| git config --global user.email "info@wp-cli.org" | ||
| git config --global user.name "wp-make-coffee" | ||
| git config --global user.email "alain.schlesser@gmail.com" | ||
| git config --global user.name "Alain Schlesser" |
There was a problem hiding this comment.
The workflow now configures git with a personal name/email. This seems unrelated to the stated revert and will cause automated commits/PRs to be attributed to an individual and exposes a personal email address in workflow history. Consider restoring the previous bot identity (e.g., the wp-cli automation user) for consistency and privacy.
Reverts #213
There are false positives for instance when a command like
checksum-commandaddswp core verify-checksums, so the action thinks it needs to be documented incore-command.Need a different approach.