Skip to content

Revert "Add workflow to detect commands missing in readme"#217

Merged
swissspidy merged 1 commit intomainfrom
revert-213-add/command-check-workflow
Mar 4, 2026
Merged

Revert "Add workflow to detect commands missing in readme"#217
swissspidy merged 1 commit intomainfrom
revert-213-add/command-check-workflow

Conversation

@swissspidy
Copy link
Member

Reverts #213

There are false positives for instance when a command like checksum-command adds wp core verify-checksums, so the action thinks it needs to be documented in core-command.

Need a different approach.

Copilot AI review requested due to automatic review settings March 4, 2026 10:25
@swissspidy swissspidy requested a review from a team as a code owner March 4, 2026 10:25
@swissspidy swissspidy merged commit 1c4df11 into main Mar 4, 2026
12 checks passed
@swissspidy swissspidy deleted the revert-213-add/command-check-workflow branch March 4, 2026 10:26
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the previously added workflow step that compared documented commands to registered WP-CLI commands, due to false positives in packages that register commands under other roots.

Changes:

  • Removes the “documented vs registered commands” verification step from the README regeneration workflow.
  • Updates the git author configuration used for automated commits created by the workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 49 to +52
- name: Configure git user
run: |
git config --global user.email "info@wp-cli.org"
git config --global user.name "wp-make-coffee"
git config --global user.email "alain.schlesser@gmail.com"
git config --global user.name "Alain Schlesser"
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow now configures git with a personal name/email. This seems unrelated to the stated revert and will cause automated commits/PRs to be attributed to an individual and exposes a personal email address in workflow history. Consider restoring the previous bot identity (e.g., the wp-cli automation user) for consistency and privacy.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants