Skip to content

Container-first validation: remove fallback docker run blocks #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wphillipmoore merged 1 commit into from
Mar 5, 2026
Merged

Container-first validation: remove fallback docker run blocks #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions scripts/dev/audit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,9 @@ set -euo pipefail
export DOCKER_DEV_IMAGE="${DOCKER_DEV_IMAGE:-dev-java:21}"
export DOCKER_TEST_CMD="${DOCKER_TEST_CMD:-./mvnw dependency:tree -B -q && ./mvnw org.codehaus.mojo:license-maven-plugin:2.7.0:add-third-party -Dlicense.excludedScopes=test -Dlicense.failIfWarning=true '-Dlicense.includedLicenses=Apache-2.0|Apache 2.0|The Apache License, Version 2.0|MIT License|BSD-2-Clause|BSD-3-Clause|ISC|MPL-2.0|GPL-3.0-or-later' -B}"

if command -v docker-test >/dev/null 2>&1; then
exec docker-test
if ! command -v docker-test >/dev/null 2>&1; then
echo "ERROR: docker-test not found on PATH." >&2
echo "Set up standard-tooling: export PATH=../standard-tooling/scripts/bin:\$PATH" >&2
exit 1
fi

# Fallback: run docker directly if docker-test is not on PATH.
repo_root="$(cd "$(dirname "$0")/../.." && pwd)"

echo "Image: ${DOCKER_DEV_IMAGE}"
echo "Command: ${DOCKER_TEST_CMD}"
echo "---"

exec docker run --rm \
-v "${repo_root}:/workspace" \
-w /workspace \
"${DOCKER_DEV_IMAGE}" \
bash -c "${DOCKER_TEST_CMD}"
exec docker-test
20 changes: 5 additions & 15 deletions scripts/dev/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,9 @@ set -euo pipefail
export DOCKER_DEV_IMAGE="${DOCKER_DEV_IMAGE:-dev-java:21}"
export DOCKER_TEST_CMD="${DOCKER_TEST_CMD:-./mvnw spotless:check checkstyle:check -B}"

if command -v docker-test >/dev/null 2>&1; then
exec docker-test
if ! command -v docker-test >/dev/null 2>&1; then
echo "ERROR: docker-test not found on PATH." >&2
echo "Set up standard-tooling: export PATH=../standard-tooling/scripts/bin:\$PATH" >&2
exit 1
fi

# Fallback: run docker directly if docker-test is not on PATH.
repo_root="$(cd "$(dirname "$0")/../.." && pwd)"

echo "Image: ${DOCKER_DEV_IMAGE}"
echo "Command: ${DOCKER_TEST_CMD}"
echo "---"

exec docker run --rm \
-v "${repo_root}:/workspace" \
-w /workspace \
"${DOCKER_DEV_IMAGE}" \
bash -c "${DOCKER_TEST_CMD}"
exec docker-test
20 changes: 5 additions & 15 deletions scripts/dev/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,9 @@ set -euo pipefail
export DOCKER_DEV_IMAGE="${DOCKER_DEV_IMAGE:-dev-java:21}"
export DOCKER_TEST_CMD="${DOCKER_TEST_CMD:-./mvnw verify -B}"

if command -v docker-test >/dev/null 2>&1; then
exec docker-test
if ! command -v docker-test >/dev/null 2>&1; then
echo "ERROR: docker-test not found on PATH." >&2
echo "Set up standard-tooling: export PATH=../standard-tooling/scripts/bin:\$PATH" >&2
exit 1
fi

# Fallback: run docker directly if docker-test is not on PATH.
repo_root="$(cd "$(dirname "$0")/../.." && pwd)"

echo "Image: ${DOCKER_DEV_IMAGE}"
echo "Command: ${DOCKER_TEST_CMD}"
echo "---"

exec docker run --rm \
-v "${repo_root}:/workspace" \
-w /workspace \
"${DOCKER_DEV_IMAGE}" \
bash -c "${DOCKER_TEST_CMD}"
exec docker-test
20 changes: 5 additions & 15 deletions scripts/dev/typecheck.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,9 @@ set -euo pipefail
export DOCKER_DEV_IMAGE="${DOCKER_DEV_IMAGE:-dev-java:21}"
export DOCKER_TEST_CMD="${DOCKER_TEST_CMD:-./mvnw compile -B}"

if command -v docker-test >/dev/null 2>&1; then
exec docker-test
if ! command -v docker-test >/dev/null 2>&1; then
echo "ERROR: docker-test not found on PATH." >&2
echo "Set up standard-tooling: export PATH=../standard-tooling/scripts/bin:\$PATH" >&2
exit 1
fi

# Fallback: run docker directly if docker-test is not on PATH.
repo_root="$(cd "$(dirname "$0")/../.." && pwd)"

echo "Image: ${DOCKER_DEV_IMAGE}"
echo "Command: ${DOCKER_TEST_CMD}"
echo "---"

exec docker run --rm \
-v "${repo_root}:/workspace" \
-w /workspace \
"${DOCKER_DEV_IMAGE}" \
bash -c "${DOCKER_TEST_CMD}"
exec docker-test