Update Java versions for the deployment#5920
Open
madurangasiriwardena wants to merge 4 commits intowso2:masterfrom
Open
Update Java versions for the deployment#5920madurangasiriwardena wants to merge 4 commits intowso2:masterfrom
madurangasiriwardena wants to merge 4 commits intowso2:masterfrom
Conversation
Contributor
WalkthroughDocumentation updates changing Java/JDK version references from 11/17 to 21/25 across deployment and setup guides, plus corresponding JAVA_HOME/path examples and a minor formatting newline in a compatibility table. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@en/identity-server/next/docs/deploy/deployment-guide.md`:
- Line 67: Update the Java requirement text in deployment-guide.md by changing
the table cell that currently reads "Open JDK 21" to "Open JDK 21 or 25" so it
matches the other docs (install.md, quick-set-up.md, product-compatibility.md);
locate the string "Open JDK 21" in the deployment guide table and replace it
with "Open JDK 21 or 25".
In `@en/identity-server/next/docs/deploy/get-started/install.md`:
- Line 317: Update the Windows example environment variable line to use
consistent casing for the Java directory: change the path in the line that sets
JAVA_HOME (the "set JAVA_HOME=..." example) to match the earlier "Java"
capitalization used elsewhere (e.g., use "c:/Program Files/Java/temurin-21.jdk")
so the guide uses one term per concept and maintains consistent Windows path
casing.
- Line 196: Remove the duplicated fragment in the sentence that currently reads
"Replace `<JDK_INSTALLATION_PATH>` with the path of your JDK installation).
directory where the JDK is installed." and replace it with a single clear
sentence such as "Replace `<JDK_INSTALLATION_PATH>` with the path of your JDK
installation." so the instruction in the Add step is concise and free of the
stray "directory where the JDK is installed." fragment.
- Line 40: The list item contains awkward phrasing and an extra period; replace
the current <li> text that starts with "WSO2 Identity Server requires JDK
compliant with Java 21 or Java 25." with a single clear sentence such as "WSO2
Identity Server requires a JDK compatible with Java 21 or Java 25." ensuring you
remove the stray closing </strong> . and keep plain, short wording in the <li>
element.
- Around line 101-102: Update the install matrix entries that currently read
"Oracle JDK 21" and "OpenJDK 21" by adding corresponding "Oracle JDK 25" and
"OpenJDK 25" entries (to match product-compatibility.md and the statement about
supporting Java 21 and 25); also standardize JDK terminology throughout this
file by replacing inconsistent variants ("Open JDK", "Temurin OpenJDK", etc.)
with a consistent pair (e.g., "Oracle JDK" and "Temurin OpenJDK" or "Oracle JDK"
and "OpenJDK") and ensure the wording that mentions "JDK compliant with Java 21
or Java 25" matches the updated list entries.
In `@en/identity-server/next/docs/get-started/quick-set-up.md`:
- Line 12: Update the wording in the quick-set-up step that currently reads
"Java SE Development Kit (JDK) version 21 or 25" to use the tested distribution
name "Temurin OpenJDK" instead (e.g., "Temurin OpenJDK versions 21 or 25");
locate and change the string in the get-started/quick-set-up.md content where
that download/install instruction appears so the guide aligns with the
product-compatibility docs.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
en/identity-server/next/docs/deploy/deployment-guide.mden/identity-server/next/docs/deploy/get-started/install.mden/identity-server/next/docs/deploy/product-compatibility.mden/identity-server/next/docs/get-started/quick-set-up.mden/identity-server/next/requirements.txt
| <tr class="even"> | ||
| <th>Java</th> | ||
| <td>Open JDK 11</td> | ||
| <td>Open JDK 21</td> |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for Java/JDK version mentions across docs
echo "=== Searching for JDK/Java version mentions ==="
rg -n 'JDK|OpenJDK|Open JDK|Java 21|Java 25|Temurin' en/identity-server/next/docs --max-count=50
echo -e "\n=== Checking line 67 context in deployment-guide.md ==="
if [ -f "en/identity-server/next/docs/deploy/deployment-guide.md" ]; then
sed -n '60,75p' "en/identity-server/next/docs/deploy/deployment-guide.md" | cat -n
fi
echo -e "\n=== Searching for version compatibility tables in docs ==="
rg -n 'compatibility|requirements|prerequisites' en/identity-server/next/docs/deploy -i | head -30Repository: wso2/docs-is
Length of output: 50370
🏁 Script executed:
#!/bin/bash
# Get the specific context around each JDK version mention
echo "=== deployment-guide.md around line 67 ==="
sed -n '60,75p' en/identity-server/next/docs/deploy/deployment-guide.md | cat -n
echo -e "\n=== install.md around line 40 ==="
sed -n '35,50p' en/identity-server/next/docs/deploy/get-started/install.md | cat -n
echo -e "\n=== quick-set-up.md around line 12 ==="
sed -n '8,20p' en/identity-server/next/docs/get-started/quick-set-up.md | cat -n
echo -e "\n=== Check product-compatibility.md for JDK table ==="
sed -n '30,60p' en/identity-server/next/docs/deploy/product-compatibility.md | cat -nRepository: wso2/docs-is
Length of output: 3801
Align Java version requirement to match other deployment documentation.
This row states only Open JDK 21, but multiple other updated docs specify Java 21 or Java 25:
install.mdline 40: "JDK compliant with Java 21 or Java 25"quick-set-up.mdline 12: "JDK version 21 or 25"product-compatibility.md(Tested JDKs table): "21, 25"
Update the deployment-guide.md entry to Open JDK 21 or 25 to maintain consistent version requirements across deployment documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@en/identity-server/next/docs/deploy/deployment-guide.md` at line 67, Update
the Java requirement text in deployment-guide.md by changing the table cell that
currently reads "Open JDK 21" to "Open JDK 21 or 25" so it matches the other
docs (install.md, quick-set-up.md, product-compatibility.md); locate the string
"Open JDK 21" in the deployment guide table and replace it with "Open JDK 21 or
25".
Comment on lines
+101
to
+102
| <li><p>Oracle JDK 21</p></li> | ||
| <li><p>OpenJDK 21</p></li> |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check JDK version declarations in install + related updated docs.
rg -n -C2 'Oracle JDK|OpenJDK|Temurin|Java 21|Java 25|JDK 25|JDK 21' \
en/identity-server/next/docs/deploy/get-started/install.md \
en/identity-server/next/docs/deploy/product-compatibility.md \
en/identity-server/next/docs/get-started/quick-set-up.md \
en/identity-server/next/docs/deploy/deployment-guide.mdRepository: wso2/docs-is
Length of output: 3030
Update install.md lines 101-102 to include JDK 25 options and align terminology.
Lines 101-102 list only Oracle JDK 21 and OpenJDK 21, but line 40 of the same file states the product requires "JDK compliant with Java 21 or Java 25." The product-compatibility.md file confirms support for Temurin OpenJDK versions 21 and 25. Add Oracle JDK 25 and OpenJDK 25 to the version matrix. Additionally, standardize JDK terminology across all docs—currently using "Oracle JDK," "OpenJDK," "Open JDK," and "Temurin OpenJDK" inconsistently.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@en/identity-server/next/docs/deploy/get-started/install.md` around lines 101
- 102, Update the install matrix entries that currently read "Oracle JDK 21" and
"OpenJDK 21" by adding corresponding "Oracle JDK 25" and "OpenJDK 25" entries
(to match product-compatibility.md and the statement about supporting Java 21
and 25); also standardize JDK terminology throughout this file by replacing
inconsistent variants ("Open JDK", "Temurin OpenJDK", etc.) with a consistent
pair (e.g., "Oracle JDK" and "Temurin OpenJDK" or "Oracle JDK" and "OpenJDK")
and ensure the wording that mentions "JDK compliant with Java 21 or Java 25"
matches the updated list entries.
|
|
||
| 1. In your home directory, open the BASHRC file (.bash_profile file on macOS) using a text editor such as vi, emacs, pico, or mcedit. | ||
| 2. Assuming you have JDK 11.0.14 in your system, add the following two lines at the bottom of the file (Replace `/usr/java/jdk-11.0.14` with the path of your JDK installation). directory where the JDK is installed. | ||
| 2. Add the following lines at the bottom of the file (Replace `<JDK_INSTALLATION_PATH>` with the path of your JDK installation). directory where the JDK is installed. |
Contributor
There was a problem hiding this comment.
Remove the duplicated sentence fragment.
...installation). directory where the JDK is installed. reads as an editing artifact and should be cleaned up.
As per coding guidelines, “Use plain language and short sentences.”
Suggested edit
-2. Add the following lines at the bottom of the file (Replace `<JDK_INSTALLATION_PATH>` with the path of your JDK installation). directory where the JDK is installed.
+2. Add the following lines at the bottom of the file (replace `<JDK_INSTALLATION_PATH>` with your JDK installation path).📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 2. Add the following lines at the bottom of the file (Replace `<JDK_INSTALLATION_PATH>` with the path of your JDK installation). directory where the JDK is installed. | |
| 2. Add the following lines at the bottom of the file (replace `<JDK_INSTALLATION_PATH>` with your JDK installation path). |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@en/identity-server/next/docs/deploy/get-started/install.md` at line 196,
Remove the duplicated fragment in the sentence that currently reads "Replace
`<JDK_INSTALLATION_PATH>` with the path of your JDK installation). directory
where the JDK is installed." and replace it with a single clear sentence such as
"Replace `<JDK_INSTALLATION_PATH>` with the path of your JDK installation." so
the instruction in the Add step is concise and free of the stray "directory
where the JDK is installed." fragment.
| **Example** | ||
| ```java | ||
| set JAVA_HOME=c:/Program Files/java/jdk-11.0.14 | ||
| set JAVA_HOME=c:/Program Files/java/temurin-21.jdk |
Contributor
There was a problem hiding this comment.
Use consistent Windows path casing in the example.
This example uses .../java/... while earlier text uses .../Java/.... Keep one form for consistency and readability in the guide.
As per coding guidelines, “Use one term per concept.”
Suggested edit
- set JAVA_HOME=c:/Program Files/java/temurin-21.jdk
+ set JAVA_HOME=C:/Program Files/Java/temurin-21.jdk📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| set JAVA_HOME=c:/Program Files/java/temurin-21.jdk | |
| set JAVA_HOME=C:/Program Files/Java/temurin-21.jdk |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@en/identity-server/next/docs/deploy/get-started/install.md` at line 317,
Update the Windows example environment variable line to use consistent casing
for the Java directory: change the path in the line that sets JAVA_HOME (the
"set JAVA_HOME=..." example) to match the earlier "Java" capitalization used
elsewhere (e.g., use "c:/Program Files/Java/temurin-21.jdk") so the guide uses
one term per concept and maintains consistent Windows path casing.
| Follow the steps given below. | ||
|
|
||
| 1. Download and install Oracle Java SE Development Kit (JDK) version 11 or 17. | ||
| 1. Download and install Java SE Development Kit (JDK) version 21 or 25. |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for JDK-related terminology in both files
echo "=== Searching quick-setup.md ==="
rg -n -C3 'Java|JDK|Temurin|OpenJDK' en/identity-server/next/docs/get-started/quick-set-up.md
echo -e "\n=== Searching product-compatibility.md ==="
rg -n -C3 'Java|JDK|Temurin|OpenJDK' en/identity-server/next/docs/deploy/product-compatibility.md
echo -e "\n=== Checking file existence ==="
ls -la en/identity-server/next/docs/get-started/quick-set-up.md 2>/dev/null || echo "quick-set-up.md not found"
ls -la en/identity-server/next/docs/deploy/product-compatibility.md 2>/dev/null || echo "product-compatibility.md not found"Repository: wso2/docs-is
Length of output: 1648
Align JDK naming with the tested configuration.
The quick-setup guide refers to "Java SE Development Kit (JDK)", but the product-compatibility documentation specifies that the product is tested with "Temurin OpenJDK" versions 21 and 25. Update the JDK reference in this step to use "Temurin OpenJDK" to match the official tested distribution and follow the guideline: use official product and feature names exactly as defined, and use one term per concept.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@en/identity-server/next/docs/get-started/quick-set-up.md` at line 12, Update
the wording in the quick-set-up step that currently reads "Java SE Development
Kit (JDK) version 21 or 25" to use the tested distribution name "Temurin
OpenJDK" instead (e.g., "Temurin OpenJDK versions 21 or 25"); locate and change
the string in the get-started/quick-set-up.md content where that
download/install instruction appears so the guide aligns with the
product-compatibility docs.
himeshsiriwardana
previously approved these changes
Feb 25, 2026
himeshsiriwardana
approved these changes
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
en/identity-server/next/docs/deploy/get-started/install.md (4)
317-317:⚠️ Potential issue | 🟡 MinorKeep the Windows path example consistent with the earlier
JAVA_HOMEpath.Line 317 switches from
C:/Program Files/Java/...toc:/Program Files/java/..., which makes the guide inconsistent for the same path example.Suggested edit
- set JAVA_HOME=c:/Program Files/java/temurin-21.jdk + set JAVA_HOME=C:/Program Files/Java/temurin-21.jdkAs per coding guidelines, “Use one term per concept; do not switch terminology mid-document or randomly mix expanded and abbreviated forms.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/identity-server/next/docs/deploy/get-started/install.md` at line 317, Update the Windows example assignment so the path matches the earlier `JAVA_HOME` casing and format: replace the inconsistent `set JAVA_HOME=c:/Program Files/java/temurin-21.jdk` with the same style used earlier (e.g. `set JAVA_HOME=C:/Program Files/Java/temurin-21.jdk`) to maintain consistent capitalization and path formatting across the document.
196-196:⚠️ Potential issue | 🟡 MinorRemove the duplicated fragment in this step.
Line 196 still has an editing artifact after the parenthetical, which makes the instruction harder to read.
Suggested edit
-2. Add the following lines at the bottom of the file (Replace `<JDK_INSTALLATION_PATH>` with the path of your JDK installation). directory where the JDK is installed. +2. Add the following lines at the bottom of the file (replace `<JDK_INSTALLATION_PATH>` with your JDK installation path).As per coding guidelines, “Use plain language and short sentences.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/identity-server/next/docs/deploy/get-started/install.md` at line 196, The instruction line contains a duplicated fragment after the parenthetical — remove the trailing words "directory where the JDK is installed." so the sentence reads cleanly as "Replace `<JDK_INSTALLATION_PATH>` with the path of your JDK installation." Update the line that begins "Add the following lines at the bottom of the file (Replace `<JDK_INSTALLATION_PATH>`..." to eliminate the duplicated fragment and ensure plain language and a short sentence.
101-102:⚠️ Potential issue | 🟠 MajorAdd the Java 25 entry here to match the prerequisite section.
Lines 101-102 still list only JDK 21, but Line 40 says the product supports Java 21 or Java 25. That contradiction can send readers to the wrong runtime during installation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/identity-server/next/docs/deploy/get-started/install.md` around lines 101 - 102, Update the JDK list to include Java 25 entries so it matches the prerequisite section: add corresponding "Oracle JDK 25" and "OpenJDK 25" list items alongside the existing "Oracle JDK 21" and "OpenJDK 21" entries to avoid the mismatch between the JDK list and the prerequisite statement.
40-40:⚠️ Potential issue | 🟡 MinorRewrite this prerequisite as one clear sentence.
Line 40 still reads awkwardly and the
Thissubject is ambiguous. A single direct sentence is easier to follow here.Suggested edit
-<li>WSO2 Identity Server requires JDK compliant with Java 21 or Java 25. This will run on most common platforms that <strong>support Java 21 or Java 25</strong>.</li> +<li>WSO2 Identity Server requires a JDK compatible with Java 21 or Java 25 and runs on platforms that <strong>support Java 21 or Java 25</strong>.</li>As per coding guidelines, “Use plain language and short sentences” and “Avoid ambiguous pronouns (it, this, that, they) by replacing them with explicit nouns when ambiguity exists.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/identity-server/next/docs/deploy/get-started/install.md` at line 40, Replace the awkward list item text "WSO2 Identity Server requires JDK compliant with Java 21 or Java 25. This will run on most common platforms that support Java 21 or Java 25." with one clear sentence that removes the ambiguous pronoun, e.g. state explicitly that WSO2 Identity Server requires a JDK compatible with Java 21 or Java 25 (use the exact phrase "WSO2 Identity Server requires a JDK compatible with Java 21 or Java 25" or similar) so the prerequisite is a single, unambiguous sentence.
🧹 Nitpick comments (1)
en/identity-server/next/docs/deploy/get-started/install.md (1)
386-386: Please align the other deployment docs with this Java 21/25 update.This example now points to Java 21, but
en/identity-server/next/docs/deploy/security/security-guidelines/product-level-security-guidelines.md:232-240still recommends JDK 11 and 17. Updating that page in the same PR would avoid contradictory deployment guidance.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/identity-server/next/docs/deploy/get-started/install.md` at line 386, The install.md update changed JAVA_HOME to Java 21 (export JAVA_HOME="/usr/java/temurin-21.jdk") but the product-level security guidelines still recommend JDK 11/17; update the security-guidelines document to align recommendations to Java 21 (or the supported 21/25 versions) and any text that lists supported JDKs, replacing references to 11/17 with the new supported versions, and ensure the JAVA_HOME example and any compatibility notes are consistent across both documents (search for "JAVA_HOME" and the "Product level security guidelines" section to locate the entries to change).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@en/identity-server/next/docs/deploy/get-started/install.md`:
- Line 262: Replace the guidance that tells readers to "choose the latest one"
with an explicit instruction to select a supported JDK version (e.g., 21 or 25);
update the sentence in the paragraph that currently reads "If you have multiple
versions installed, choose the latest one" to instead say something like "If you
have multiple versions installed, choose a supported JDK (for example, 21 or
25)" so readers will not accidentally pick an unsupported JDK.
---
Duplicate comments:
In `@en/identity-server/next/docs/deploy/get-started/install.md`:
- Line 317: Update the Windows example assignment so the path matches the
earlier `JAVA_HOME` casing and format: replace the inconsistent `set
JAVA_HOME=c:/Program Files/java/temurin-21.jdk` with the same style used earlier
(e.g. `set JAVA_HOME=C:/Program Files/Java/temurin-21.jdk`) to maintain
consistent capitalization and path formatting across the document.
- Line 196: The instruction line contains a duplicated fragment after the
parenthetical — remove the trailing words "directory where the JDK is
installed." so the sentence reads cleanly as "Replace `<JDK_INSTALLATION_PATH>`
with the path of your JDK installation." Update the line that begins "Add the
following lines at the bottom of the file (Replace `<JDK_INSTALLATION_PATH>`..."
to eliminate the duplicated fragment and ensure plain language and a short
sentence.
- Around line 101-102: Update the JDK list to include Java 25 entries so it
matches the prerequisite section: add corresponding "Oracle JDK 25" and "OpenJDK
25" list items alongside the existing "Oracle JDK 21" and "OpenJDK 21" entries
to avoid the mismatch between the JDK list and the prerequisite statement.
- Line 40: Replace the awkward list item text "WSO2 Identity Server requires JDK
compliant with Java 21 or Java 25. This will run on most common platforms that
support Java 21 or Java 25." with one clear sentence that removes the ambiguous
pronoun, e.g. state explicitly that WSO2 Identity Server requires a JDK
compatible with Java 21 or Java 25 (use the exact phrase "WSO2 Identity Server
requires a JDK compatible with Java 21 or Java 25" or similar) so the
prerequisite is a single, unambiguous sentence.
---
Nitpick comments:
In `@en/identity-server/next/docs/deploy/get-started/install.md`:
- Line 386: The install.md update changed JAVA_HOME to Java 21 (export
JAVA_HOME="/usr/java/temurin-21.jdk") but the product-level security guidelines
still recommend JDK 11/17; update the security-guidelines document to align
recommendations to Java 21 (or the supported 21/25 versions) and any text that
lists supported JDKs, replacing references to 11/17 with the new supported
versions, and ensure the JAVA_HOME example and any compatibility notes are
consistent across both documents (search for "JAVA_HOME" and the "Product level
security guidelines" section to locate the entries to change).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 834b8998-e0bc-4a90-9b2a-6fa94e93d56c
📒 Files selected for processing (1)
en/identity-server/next/docs/deploy/get-started/install.md
| #### Set up JAVA_HOME | ||
|
|
||
| You must set your `JAVA_HOME` environment variable to point to the directory where the Java Development Kit (JDK) is installed on the computer. Typically, the JDK is installed in a directory under `C:/Program Files/Java`, such as `C:/Program Files/Java/jdk-11.0.14` . If you have multiple versions installed, choose the latest one, which you can find by sorting by date. | ||
| You must set your `JAVA_HOME` environment variable to point to the directory where the Java Development Kit (JDK) is installed on the computer. Typically, the JDK is installed in a directory under `C:/Program Files/Java`, such as `C:/Program Files/Java/temurin-21.jdk` . If you have multiple versions installed, choose the latest one, which you can find by sorting by date. |
Contributor
There was a problem hiding this comment.
Do not tell readers to pick the latest installed JDK.
Line 262 can direct readers to an unsupported version if they also have a newer JDK installed. Please tell them to select a supported JDK, explicitly 21 or 25, instead of "the latest one."
Suggested edit
-You must set your `JAVA_HOME` environment variable to point to the directory where the Java Development Kit (JDK) is installed on the computer. Typically, the JDK is installed in a directory under `C:/Program Files/Java`, such as `C:/Program Files/Java/temurin-21.jdk` . If you have multiple versions installed, choose the latest one, which you can find by sorting by date.
+You must set your `JAVA_HOME` environment variable to point to the directory where the Java Development Kit (JDK) is installed on the computer. Typically, the JDK is installed in a directory under `C:/Program Files/Java`, such as `C:/Program Files/Java/temurin-21.jdk`. If you have multiple JDK versions installed, choose a supported version: Java 21 or Java 25.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| You must set your `JAVA_HOME` environment variable to point to the directory where the Java Development Kit (JDK) is installed on the computer. Typically, the JDK is installed in a directory under `C:/Program Files/Java`, such as `C:/Program Files/Java/temurin-21.jdk` . If you have multiple versions installed, choose the latest one, which you can find by sorting by date. | |
| You must set your `JAVA_HOME` environment variable to point to the directory where the Java Development Kit (JDK) is installed on the computer. Typically, the JDK is installed in a directory under `C:/Program Files/Java`, such as `C:/Program Files/Java/temurin-21.jdk`. If you have multiple JDK versions installed, choose a supported version: Java 21 or Java 25. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@en/identity-server/next/docs/deploy/get-started/install.md` at line 262,
Replace the guidance that tells readers to "choose the latest one" with an
explicit instruction to select a supported JDK version (e.g., 21 or 25); update
the sentence in the paragraph that currently reads "If you have multiple
versions installed, choose the latest one" to instead say something like "If you
have multiple versions installed, choose a supported JDK (for example, 21 or
25)" so readers will not accidentally pick an unsupported JDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit