Update the refresh token configurations.#5960
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe "Extend expiry time of renewed refresh token" subsection was wrapped in a conditional so it is shown only for Asgardeo or WSO2 Identity Server versions > 7.2.0; the heading, a note, and the explanatory sentence about remaining-token validity were moved inside that conditional. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md (1)
16-16: Consider clarifying the configuration reference.The phrase "this configuration" assumes context from surrounding UI or documentation. For improved standalone clarity, consider explicitly naming the configuration setting (e.g., "When you disable the Extend expiry time option..." or similar, depending on the actual UI label).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md` at line 16, Replace the ambiguous phrase "When you set this configuration to `false`" with an explicit reference to the configuration option by name (for example, "When you disable the Extend expiry time option" or the actual UI label), so the sentence reads clearly on its own; update the sentence in refresh-token.md to mention the specific setting name (e.g., "Extend expiry time") instead of "this configuration" and keep the rest of the sentence ("renewed refresh tokens carry the remaining validity period of the original refresh token") unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md`:
- Around line 10-11: The heading "Extend expiry time of renewed refresh token"
is using level 3 (###) while surrounding configuration headings use level 4;
change that heading to level 4 (####) inside the same conditional block (the
line with {% if product_name == "Asgardeo" or (product_name == "WSO2 Identity
Server" and is_version > "7.2.0" ) %}) so it matches the other configuration
section headings and preserves the correct hierarchy.
---
Nitpick comments:
In `@en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md`:
- Line 16: Replace the ambiguous phrase "When you set this configuration to
`false`" with an explicit reference to the configuration option by name (for
example, "When you disable the Extend expiry time option" or the actual UI
label), so the sentence reads clearly on its own; update the sentence in
refresh-token.md to mention the specific setting name (e.g., "Extend expiry
time") instead of "this configuration" and keep the rest of the sentence
("renewed refresh tokens carry the remaining validity period of the original
refresh token") unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3c362c08-e6c8-43f4-bb5b-4f5327117be1
📒 Files selected for processing (1)
en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md
en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md
Outdated
Show resolved
Hide resolved
…token.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1d6966e
Purpose
Related PRs
Extend expiry time of renewed refresh tokenapplication configuration. #5813Test environment
Security checks
Summary by CodeRabbit