Skip to content

Update Create-PullRequest.md #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
donohoe14 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Create-PullRequest.md #953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ch3_pull-request/Create-PullRequest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,31 +6,31 @@ In Chapter 3 - _Teamwork and Collaborative Development_ we learn how to collabo

2. Delete the following line:

__Delete this line__


3. Add one or two lines here with a random text:
line 1
line 2

__...__
5. Modify the following line by removing the letters that do not belong:

4. Modify the following line by removing the letters that do not belong:
__---> The cow jumped ovverr the moon__

__---> The ccow jumpedd ovverr thhe mooon__

5. Commit your changes into a new _branch_:
6. Commit your changes into a new _branch_:

![Commit Changes](img/commit.png)

6. In the next screen create the pull request by completing the title and description. Note the complete markdown support that we've seen in Chapter 2 for issues:
7. In the next screen create the pull request by completing the title and description. Note the complete markdown support that we've seen in Chapter 2 for issues:

![Create pr](img/create-pr.png)

Make sure that the pull request uses base:main and not the upstream repository. This should be correct by default.

7. Got to `Files changed` and note the changes (deleted lines red, added lines green). Add a comment to a line by clicking the `+`at the beginning of the line when hovering with the mouse over it. Add a comment to line nine and click `Add single comment`.
8. Got to `Files changed` and note the changes (deleted lines red, added lines green). Add a comment to a line by clicking the `+`at the beginning of the line when hovering with the mouse over it. Add a comment to line nine and click `Add single comment`.

![Comment on changes](img/comment.png)

8. Edit the file opening the menu in the top right corner and selecting `Edit file`.
9. Edit the file opening the menu in the top right corner and selecting `Edit file`.

![Edit file](img/edit-file.png)

Expand Down