fix: Update ege_roundrect to include PIMAGE parameter#361
fix: Update ege_roundrect to include PIMAGE parameter#361wysaid merged 1 commit intox-ege:masterfrom
Conversation
概述在 变更
代码审查工作量🎯 2 (Simple) | ⏱️ ~8 分钟 诗
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: Fixes 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @src/egegapi.cpp:
- Around line 2023-2026: The 9-argument overloads ege_roundrect(...) and
ege_fillroundrect(...) call CONVERT_IMAGE and then use img->getGraphics()
without checking for NULL; replicate the defensive pattern from ege_rectangle by
wrapping the code that calls img->getGraphics() and manipulates img inside an if
(img) { ... } block after CONVERT_IMAGE returns to avoid dereferencing a NULL
img when CONVERT_IMAGE returns NULL. Ensure all uses of img in those functions
are guarded and that the function returns/cleans up appropriately if img is
NULL.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/egegapi.cpp
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{h,hpp,cpp,cc,cxx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
All implementations must be in
egenamespace, with public API in global namespace
Files:
src/egegapi.cpp
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: macOS Cross-Compile - Debug
- GitHub Check: MSYS2 Latest - Debug
- GitHub Check: MSYS2 Latest - Release
- GitHub Check: MSVC 2022 Build (Release)
|
@yixy-only 这个应该是之前 ege_fillroundrect 改剩下的 |
|
@FeJS8888 合入了~ |
Summary by CodeRabbit
新增功能
✏️ Tip: You can customize this high-level summary in your review settings.