Skip to content

IDebugLogs to Game/Logs folder #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JayLCypher wants to merge 8 commits into
base: master
Choose a base branch
from
Open

IDebugLogs to Game/Logs folder #45

JayLCypher wants to merge 8 commits into from

Conversation

@JayLCypher
Copy link

@JayLCypher JayLCypher commented Jul 10, 2021 •
edited
Loading

Changes to IDebugLogs to update it and move the logs created by xNVSE to be located in Logs folder in Game folder (C:\Steam\SteamApps\Common\Fallout New Vegas) for easier access over installed plugins, if such a feature is desired.

Tested with debug/release compile and with MO2 modded setup.

lStewieAl
lStewieAl requested changes Jul 10, 2021
View reviewed changes
Copy link
Contributor

@lStewieAl lStewieAl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't included the ID in case creating the log fails (e.g. if the file is already open)

@JayLCypher
Copy link
Author

JayLCypher commented Jul 10, 2021

You haven't included the ID in case creating the log fails (e.g. if the file is already open)

Updated with file ID handle.
Checked Debug that it spawns another log file when nvse.log and log0 exists, creating nvse.log1.
Checked Release that it spawns another log file when other logs have id 1.
Also opened it in MO2 with a modded setup using executeable.

@JayLCypher JayLCypher closed this Jul 10, 2021
@JayLCypher JayLCypher reopened this Jul 10, 2021
@JayLCypher JayLCypher requested a review from lStewieAl July 10, 2021 23:54
@korri123
Copy link
Member

korri123 commented Jul 14, 2021

If you could make this change optional through INI then that'd be great. I myself am not keen on having the file in a Logs folder since I frequently look at logs and it's handy for me to have the base game folder open at all times and I can just use my keyboard to find it quickly to open it.

JayLCypher and others added 5 commits December 9, 2021 15:51
@JayLCypher
Merge branch 'xNVSE:master' into master
a925dee
@JayLCypher
Merge branch 'xNVSE:master' into master
b8444ec
@JayLCypher
merged those last changes :pepe_weird_bruh:
1c9a3eb 
Moved a lot to cppLatest

Also fixed some offbyone errors in enum type checks where enum MAX was included, meaning arrays were accessed out-of-bounds.
@JayLCypher
merged those last changes :pepe_weird_bruh:
310c675 
Moved lots to CppLatest.
Fixed a few off-by-one bugs in enum evaluation (MAX was included where array sizes were MAX-1)
Some other misc changes.
@JayLCypher
fixed up containers.h m.m.
0212e06
@AVeryUncreativeUsername
Copy link
Contributor

AVeryUncreativeUsername commented Aug 12, 2023

So this thing has been open for two years. Do you think it is time to close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lStewieAl lStewieAl Awaiting requested review from lStewieAl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JayLCypher @korri123 @AVeryUncreativeUsername @lStewieAl